Fix Phabricator's --trace command

Fixes #405

Author: tomrittervg

apis/phabricator.py

@@ -49,7 +49,12 @@ def submit_to_phabricator(rev_id, retry_attempt=None):
                 cmd.append(rev_id)
             cmd.append("--")
 
-            ret = self.run(cmd)
+            ret = self.run(cmd, clean_return=False)
+            if ret.returncode == 255 and retry_attempt > 1:
+                pass  # --trace results in this return code
+            else:
+                ret.check_returncode()
+
             output = ret.stdout.decode()
 
             phab_revision = False

tests/functionality_all_platforms.py

@@ -709,7 +709,7 @@ def phab_submit(cmd):
                 raise Exception("No worky!")
             if "--trace" not in cmd:
                 raise Exception("Expected to see --trace in the phabricator command")
-            return ARC_OUTPUT % (83000 + 50, 83000 + 50)
+            return (255, ARC_OUTPUT % (83000 + 50, 83000 + 50))
 
         library_filter = 'dav1d'
         (u, expected_values, _check_jobs) = self._setup(

tests/mock_commandprovider.py

@@ -72,6 +72,12 @@ def run(self, args, shell=False, clean_return=True):
 
         if stdout is None:
             self.logger.log("We did not find a mapped response for the command `%s`." % argument_string, level=LogLevel.Warning)
+
+        def check_returncode():
+            if returncode != 0:
+                raise subprocess.CalledProcessError(returncode, argument_string)
+            pass
         return Struct(**{'stdout':
                          Struct(**{'decode': lambda: stdout}),
-                         'returncode': returncode})
+                         'returncode': returncode,
+                         'check_returncode': check_returncode})