Merge pull request #33 from tomas321/minor_recommendations

Minor recommendations

Author: mrlesmithjr

tasks/config_storage_pools.yml

@@ -1,5 +1,12 @@
 ---
 
+- name: config_storage pools | ensure storage pool paths exist
+  become: true
+  file:
+    path: "{{ item['path'] }}"
+    state: directory
+  loop: "{{ kvm_storage_pools }}"
+
 - name: config_storage_pools | defining storage pools
   become: true
   virt_pool:
@@ -9,7 +16,7 @@
   register: kvm_pools_defined
   loop: "{{ kvm_storage_pools }}"
 
-- name: config_virtual networks | setting state of storage pools
+- name: config_storage pools | setting state of storage pools
   become: true
   virt_pool:
     name: "{{ item['name'] }}"

tasks/system_tweaks.yml

@@ -6,4 +6,5 @@
     value: "{{ item['value'] }}"
     state: "{{ item['state'] }}"
     reload: true
+    ignoreerrors: true
   loop: "{{ kvm_sysctl_settings }}"

templates/vm-network.xml.j2

@@ -35,18 +35,22 @@
 {% endif %}
 {% if item['vlans'] is defined %}
 {%   for vl in item['vlans'] %}
-  <portgroup name='{{ vl['name'] }}'>
-{%     if not vl['trunk'] %}
+  <portgroup name='{{ vl['name'] }}'{{ vl['default'] | default(false) | ternary(" default='yes'", "") }}>
+{%     if vl['trunk'] is undefined and vl['default'] | default(false) %}
+  </portgroup>
+{%     elif not vl['trunk'] %}
     <vlan>
       <tag id='{{ vl['vlan'] }}'/>
+    </vlan>
+  </portgroup>
 {%     elif vl['trunk'] %}
     <vlan trunk='yes'>
 {%       for vlt in vl['vlan'] %}
       <tag id='{{ vlt }}'/>
 {%       endfor %}
-{%     endif %}
     </vlan>
-   </portgroup>
+  </portgroup>
+{%     endif %}
 {%   endfor %}
 {% endif %}
 {% if item['vlan'] is defined %}