Skip to content

Commit 8922601

Browse files
author
Felipe Rodriguez Esturo
committed
small changes
1 parent 99eec90 commit 8922601

File tree

4 files changed

+13
-7
lines changed

4 files changed

+13
-7
lines changed

package/android/src/main/java/com/mrousavy/camera/react/CameraView.kt

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,6 @@ import android.view.Gravity
77
import android.view.ScaleGestureDetector
88
import android.widget.FrameLayout
99
import androidx.camera.view.PreviewView
10-
import com.facebook.react.bridge.ReactApplicationContext
11-
import com.facebook.react.bridge.WritableMap
12-
import com.facebook.react.modules.core.DeviceEventManagerModule
1310
import com.google.mlkit.vision.barcode.common.Barcode
1411
import com.mrousavy.camera.core.CameraConfiguration
1512
import com.mrousavy.camera.core.CameraSession
@@ -80,6 +77,7 @@ class CameraView(context: Context) :
8077
var photoHdr = false
8178
var videoBitRateOverride: Double? = null
8279
var videoBitRateMultiplier: Double? = null
80+
8381
// TODO: Use .BALANCED once CameraX fixes it https://issuetracker.google.com/issues/337214687
8482
var photoQualityBalance = QualityBalance.SPEED
8583
var lowLightBoost = false

package/android/src/main/java/com/mrousavy/camera/react/CameraViewModule.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ import kotlinx.coroutines.asCoroutineDispatcher
3333
import kotlinx.coroutines.cancel
3434
import kotlinx.coroutines.isActive
3535
import kotlinx.coroutines.launch
36-
import kotlin.math.max
37-
3836

3937
@ReactModule(name = CameraViewModule.TAG)
4038
@Suppress("unused")
@@ -54,6 +52,7 @@ class CameraViewModule(reactContext: ReactApplicationContext) : ReactContextBase
5452
}
5553
}
5654
}
55+
5756
private val backgroundCoroutineScope = CoroutineScope(CameraQueues.cameraExecutor.asCoroutineDispatcher())
5857

5958
override fun invalidate() {

package/android/src/main/java/com/mrousavy/camera/react/Events.kt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ class CameraCodeScannedEvent(surfaceId: Int, viewId: Int, private val data: Writ
9898
Event<CameraCodeScannedEvent>(surfaceId, viewId) {
9999
override fun getEventName() = EVENT_NAME
100100
override fun getEventData() = data
101-
102101
companion object {
103102
const val EVENT_NAME = "topCameraCodeScanned"
104103
}

package/src/types/CameraProps.ts

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,17 @@ export interface CameraProps extends ViewProps {
417417
*/
418418
codeScanner?: CodeScanner
419419
/**
420-
* Called whenever the video is written to the file.
420+
* Used to get the bytes written to the video file on real time while it is being recorded
421+
*
422+
* @see See [the Code Scanner documentation](https://react-native-vision-camera.com/docs/guides/code-scanning) for more information
423+
* @example
424+
* ```tsx
425+
* const onBytesWrittenVideo = (bytes: number) => {
426+
* console.log(`Bytes written: ${bytes}`)
427+
* }
428+
*
429+
* return <Camera {...props} onBytesWrittenVideo={onBytesWrittenVideo} />
430+
* ```
421431
*/
422432
onBytesWrittenVideo?: (bytes: number) => void
423433
//#endregion

0 commit comments

Comments
 (0)