fix: Avoid calling getJSModule in init on Android (#3623)

n-kulic · web-flow · commit fa488782b2c3 · 2025-09-08T13:06:33.000+02:00
sendAvailableDevicesChangedEvent() calls getJSModule from init, causing IllegalStateException: "getJSModule should only happen once initialize() has been called".
diff --git a/package/android/src/main/java/com/mrousavy/camera/react/CameraDevicesManager.kt b/package/android/src/main/java/com/mrousavy/camera/react/CameraDevicesManager.kt
@@ -71,14 +71,14 @@ class CameraDevicesManager(private val reactContext: ReactApplicationContext) :
       } catch (error: Throwable) {
         Log.e(TAG, "Failed to initialize ProcessCameraProvider/ExtensionsManager! Error: ${error.message}", error)
       }
-      sendAvailableDevicesChangedEvent()
     }
   }
 
   // Note: initialize() will be called after getConstants on new arch!
   override fun initialize() {
     super.initialize()
     cameraManager.registerAvailabilityCallback(callback, null)
+    sendAvailableDevicesChangedEvent()
   }
 
   override fun invalidate() {

Original file line number	Diff line number	Diff line change
`@@ -71,14 +71,14 @@ class CameraDevicesManager(private val reactContext: ReactApplicationContext) :`
`71`	`71`	`} catch (error: Throwable) {`
`72`	`72`	`Log.e(TAG, "Failed to initialize ProcessCameraProvider/ExtensionsManager! Error: ${error.message}", error)`
`73`	`73`	`}`
`74`		`- sendAvailableDevicesChangedEvent()`
`75`	`74`	`}`
`76`	`75`	`}`
`77`	`76`
`78`	`77`	`// Note: initialize() will be called after getConstants on new arch!`
`79`	`78`	`override fun initialize() {`
`80`	`79`	`super.initialize()`
`81`	`80`	`cameraManager.registerAvailabilityCallback(callback, null)`
	`81`	`+ sendAvailableDevicesChangedEvent()`
`82`	`82`	`}`
`83`	`83`
`84`	`84`	`override fun invalidate() {`