Allows zero characters match for a wildcard

Author: kettanaito

src/pathToRegExp.test.ts

@@ -33,14 +33,14 @@ describe('pathToRegExp', () => {
   describe('given a path with a wildcard', () => {
     it('should handle wildcard', () => {
       const exp = pathToRegExp('/user/*/shipping')
-      expect(exp).toEqual(/\/user\/.+\/shipping(\/|$)/gi)
+      expect(exp).toEqual(/\/user\/.*\/shipping(\/|$)/gi)
     })
   })
 
   describe('given a path with parameter and wildcard', () => {
     it('should handle both', () => {
       const exp = pathToRegExp('/user/:userId/*')
-      expect(exp).toEqual(/\/user\/(?<userId>[^/]+?)\/.+(\/|$)/gi)
+      expect(exp).toEqual(/\/user\/(?<userId>[^/]+?)\/.*(\/|$)/gi)
     })
   })
 

src/pathToRegExp.ts

@@ -12,12 +12,12 @@ export const pathToRegExp = (path: string): RegExp => {
     .replace(/\?/g, '\\?')
     // Ignore trailing slashes
     .replace(/\/+$/, '')
-    // Replace wildcard with any single character sequence
-    .replace(/\*+/g, '.+')
+    // Replace wildcard with any zero-to-any character sequence
+    .replace(/\*+/g, '.*')
     // Replace parameters with named capturing groups
     .replace(
       /:([^\d|^\/][a-zA-Z0-9_]*(?=(?:\/|\\.)|$))/g,
-      (_, match) => `(?<${match}>[^\/]+?)`,
+      (_, paramName) => `(?<${paramName}>[^\/]+?)`,
     )
     // Allow optional trailing slash
     .concat('(\\/|$)')

test/path.test.ts

@@ -288,6 +288,25 @@ runner('Path', [
       },
     ],
   },
+  {
+    given: '/user/details*',
+    when: [
+      {
+        actual: '/user/details',
+        it: {
+          matches: true,
+          params: null,
+        },
+      },
+      {
+        actual: '/user/details/arbitrary',
+        it: {
+          matches: true,
+          params: null,
+        },
+      },
+    ],
+  },
 
   /**
    * Parameter and wildcard