Fix: Correct LCSMatch logic for repeated tokens #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation of `LCSMatch` used a set-based check to quickly filter out non-matching sequences. However, this logic was flawed and would incorrectly reject matches when the input sequence contained many repeated tokens, as this would make `len(set(seq))` artificially small. This commit removes the faulty set-based check and relies solely on the more accurate LCS algorithm for matching. A new test case has been added to verify that the fix works as expected. Fixes #1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
LCSMatchused a set-based check to quickly filter out non-matching sequences. However, this logic was flawed and would incorrectly reject matches when the input sequence contained many repeated tokens, as this would makelen(set(seq))artificially small.This commit removes the faulty set-based check and relies solely on the more accurate LCS algorithm for matching. A new test case has been added to verify that the fix works as expected.
Fixes #1