Skip to content

Lazy initialize Options executors #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
scottf merged 7 commits into from
Dec 4, 2025
Merged

Lazy initialize Options executors #1492

scottf merged 7 commits into from
Dec 4, 2025

Conversation

@scottf
Copy link
Contributor

@scottf scottf commented Dec 3, 2025 •
edited
Loading

Lazy initialize executors so as not to keep making instances if the option getter is called repeatedly.

@scottf scottf changed the title Lazy init executors Lazy initialize Options executors Dec 3, 2025
@scottf scottf requested a review from MauriceVanVeen December 3, 2025 16:47
MauriceVanVeen
MauriceVanVeen approved these changes Dec 4, 2025
View reviewed changes
Copy link
Member

@MauriceVanVeen MauriceVanVeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scottf scottf merged commit f7d5f1e into main Dec 4, 2025
5 checks passed
@scottf scottf deleted the lazy-executors branch December 4, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MauriceVanVeen MauriceVanVeen MauriceVanVeen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scottf @MauriceVanVeen