Skip to content

Commit aab5c91

Browse files
committed
Merge branch 'nosammai/main'
2 parents d25fab3 + 66feef9 commit aab5c91

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

nats/aio/client.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -985,9 +985,9 @@ async def flush(self, timeout: int = 10) -> None:
985985
raise errors.TimeoutError
986986

987987
@property
988-
def connected_url(self) -> Optional[str]:
988+
def connected_url(self) -> Optional[ParseResult]:
989989
if self._current_server and self.is_connected:
990-
return str(self._current_server.uri)
990+
return self._current_server.uri
991991
return None
992992

993993
@property

tests/test_client.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import ssl
55
import time
66
import unittest
7+
import urllib
78
from unittest import mock
89

910
import pytest
@@ -37,6 +38,7 @@ def test_default_connect_command(self):
3738
expected = f'CONNECT {{"echo": true, "lang": "python3", "pedantic": false, "protocol": 1, "verbose": false, "version": "{__version__}"}}\r\n'
3839
self.assertEqual(expected.encode(), got)
3940

41+
4042
def test_default_connect_command_with_name(self):
4143
nc = NATS()
4244
nc.options["verbose"] = False
@@ -53,16 +55,18 @@ class ClientTest(SingleServerTestCase):
5355

5456
@async_test
5557
async def test_default_connect(self):
56-
nc = NATS()
57-
await nc.connect()
58+
nc = await nats.connect()
5859
self.assertIn('server_id', nc._server_info)
5960
self.assertIn('client_id', nc._server_info)
6061
self.assertIn('max_payload', nc._server_info)
6162
self.assertEqual(nc._server_info['max_payload'], nc.max_payload)
6263
self.assertTrue(nc.max_payload > 0)
6364
self.assertTrue(nc.is_connected)
6465
self.assertTrue(nc.client_id > 0)
66+
self.assertEqual(type(nc.connected_url), urllib.parse.ParseResult)
6567
await nc.close()
68+
69+
self.assertEqual(nc.connected_url, None)
6670
self.assertTrue(nc.is_closed)
6771
self.assertFalse(nc.is_connected)
6872

0 commit comments

Comments
 (0)