ReviewResult state for generated diffs

Author: keugenek

agent/api/agent_server/models.py

@@ -27,7 +27,7 @@ class MessageKind(str, Enum):
     STAGE_RESULT = "StageResult"  # tool was used, and FSM state is expected to be updated
     RUNTIME_ERROR = "RuntimeError"  #  things went wrong!
     REFINEMENT_REQUEST = "RefinementRequest"  # no tool was used, meaning the agent is asking for more information
-    FINAL_RESULT = "FinalResult"  # generation completed successfully
+    REVIEW_RESULT = "ReviewResult"  # generation completed successfully
 
 
 class UserMessage(BaseModel):

agent/api/agent_server/test_async_agent.py

@@ -43,7 +43,7 @@ async def test_async_agent_message_endpoint(agent_type):
                 case AgentSseEvent():
                     assert event.trace_id == request.trace_id, f"Trace IDs do not match in model objects with agent_type={agent_type}"
                     assert event.status == AgentStatus.IDLE
-                    assert event.message.kind in (MessageKind.STAGE_RESULT, MessageKind.FINAL_RESULT), f"Message kind {event.message.kind} is not one of the expected kinds"
+                    assert event.message.kind in (MessageKind.STAGE_RESULT, MessageKind.REVIEW_RESULT), f"Message kind {event.message.kind} is not one of the expected kinds"
 
 
 async def test_async_agent_state_continuation(trpc_agent):

agent/trpc_agent/agent_session.py

@@ -235,7 +235,7 @@ async def process(self, request: AgentRequest, event_tx: MemoryObjectSendStream[
                         traceId=self.trace_id,
                         message=AgentMessage(
                             role="assistant",
-                            kind=MessageKind.STAGE_RESULT,
+                            kind=MessageKind.REVIEW_RESULT,
                             content=json.dumps([x.to_dict() for x in messages], sort_keys=True),
                             agentState={"fsm_state": fsm_state} if fsm_state else None,
                             unifiedDiff=initial_template_diff,
@@ -294,7 +294,7 @@ async def process(self, request: AgentRequest, event_tx: MemoryObjectSendStream[
                             traceId=self.trace_id,
                             message=AgentMessage(
                                 role="assistant",
-                                kind=MessageKind.FINAL_RESULT,
+                                kind=MessageKind.REVIEW_RESULT,
                                 content=json.dumps([x.to_dict() for x in messages], sort_keys=True),
                                 agentState={"fsm_state": fsm_state} if fsm_state else None,
                                 unifiedDiff=final_diff,
@@ -317,7 +317,7 @@ async def process(self, request: AgentRequest, event_tx: MemoryObjectSendStream[
                             traceId=self.trace_id,
                             message=AgentMessage(
                                 role="assistant",
-                                kind=MessageKind.FINAL_RESULT,
+                                kind=MessageKind.STAGE_RESULT,
                                 content=json.dumps([x.to_dict() for x in messages], sort_keys=True),
                                 agentState={"fsm_state": fsm_state} if fsm_state else None,
                                 unifiedDiff=None,
@@ -335,7 +335,6 @@ async def process(self, request: AgentRequest, event_tx: MemoryObjectSendStream[
                 if not self.user_answered(new_messages) or is_completed:
                     break
 
-
         except Exception as e:
             logger.exception(f"Error in process: {str(e)}")
             error_event = AgentSseEvent(