[evals] Fix test run and typecheck for trpc - install modules scripts for client + server

Author: keugenek

klaudbiusz/cli/eval/dbx-sdk/common.sh

@@ -0,0 +1,12 @@
+#!/bin/bash
+
+# Common functions for DBX SDK eval scripts
+
+install_dependencies() {
+    if [ -f "package.json" ]; then
+        if [ ! -d "node_modules" ]; then
+            echo "Installing dependencies..." >&2
+            npm install >&2 || { echo "❌ Failed to install dependencies" >&2; exit 1; }
+        fi
+    fi
+}

klaudbiusz/cli/eval/dbx-sdk/typecheck.sh

@@ -4,6 +4,12 @@ set -e
 # DBX SDK template typecheck script
 # Runs TypeScript type checking using npm run check or tsc directly
 
+# Source common functions
+source "$(dirname "$0")/common.sh"
+
+# Install dependencies if needed
+install_dependencies
+
 # Verify package.json exists
 if [ ! -f "package.json" ]; then
     echo "❌ Error: No package.json found" >&2

klaudbiusz/cli/eval/docker/common.sh

@@ -0,0 +1,28 @@
+#!/bin/bash
+
+# Common functions for Docker eval scripts
+
+install_dependencies() {
+    echo "Ensuring dependencies are installed..." >&2
+
+    # Check if root package.json has install:all script (trpc style)
+    if [ -f "package.json" ] && grep -q '"install:all"' package.json 2>/dev/null; then
+        echo "Running npm run install:all..." >&2
+        npm run install:all >&2 || { echo "❌ Failed to install dependencies" >&2; exit 1; }
+    elif [ -f "package.json" ] && [ ! -d "node_modules" ]; then
+        # Root-level app (dbx-sdk style)
+        echo "Installing dependencies..." >&2
+        npm install >&2 || { echo "❌ Failed to install dependencies" >&2; exit 1; }
+    else
+        # Install server/client separately if they exist
+        if [ -d "server" ] && [ -f "server/package.json" ] && [ ! -d "server/node_modules" ]; then
+            echo "Installing server dependencies..." >&2
+            cd server && npm install >&2 && cd .. || { echo "❌ Failed to install server dependencies" >&2; exit 1; }
+        fi
+
+        if [ -d "client" ] && [ -f "client/package.json" ] && [ ! -d "client/node_modules" ]; then
+            echo "Installing client dependencies..." >&2
+            cd client && npm install >&2 && cd .. || { echo "❌ Failed to install client dependencies" >&2; exit 1; }
+        fi
+    fi
+}

klaudbiusz/cli/eval/docker/test.sh

@@ -5,6 +5,12 @@ set -e
 # For Docker apps, we run tests before the Docker build
 # Docker apps are typically built from dbx-sdk or trpc templates
 
+# Source common functions
+source "$(dirname "$0")/common.sh"
+
+# Install dependencies if needed
+install_dependencies
+
 # Try root-level test (works for both dbx-sdk and trpc)
 if [ -f "package.json" ] && grep -q '"test"' package.json 2>/dev/null; then
     # Check if test files exist

klaudbiusz/cli/eval/docker/typecheck.sh

@@ -5,6 +5,12 @@ set -e
 # For Docker apps, we check the source before the Docker build
 # Docker apps are typically built from dbx-sdk or trpc templates
 
+# Source common functions
+source "$(dirname "$0")/common.sh"
+
+# Install dependencies if needed
+install_dependencies
+
 # Try root-level check first (dbx-sdk style)
 if [ -f "package.json" ] && grep -q '"check"' package.json 2>/dev/null; then
     exec npm run check
@@ -21,8 +27,9 @@ if [ -d "server" ] && [ -f "server/tsconfig.json" ]; then
     cd server && npx tsc --noEmit --skipLibCheck && cd ..
 
     # Also check client if exists
-    if [ -d "../client" ] && [ -f "../client/tsconfig.json" ]; then
-        cd ../client && npx tsc --noEmit --skipLibCheck
+    if [ -d "client" ] && [ -f "client/tsconfig.json" ]; then
+        echo "Checking client types..." >&2
+        cd client && npx tsc --noEmit --skipLibCheck
     fi
     exit 0
 fi

klaudbiusz/cli/eval/trpc/common.sh

@@ -0,0 +1,34 @@
+#!/bin/bash
+
+# Common functions for tRPC eval scripts
+
+install_dependencies() {
+    echo "Ensuring dependencies are installed..." >&2
+
+    # Check if root package.json has install:all script
+    if [ -f "package.json" ] && grep -q '"install:all"' package.json 2>/dev/null; then
+        echo "Running npm run install:all..." >&2
+        npm run install:all >&2 || { echo "❌ Failed to install dependencies" >&2; exit 1; }
+    else
+        # Install server dependencies if needed
+        if [ -d "server" ] && [ -f "server/package.json" ]; then
+            if [ ! -d "server/node_modules" ]; then
+                echo "Installing server dependencies..." >&2
+                cd server && npm install >&2 && cd .. || { echo "❌ Failed to install server dependencies" >&2; exit 1; }
+            fi
+        fi
+
+        # Install client dependencies if needed (try both client/ and frontend/)
+        if [ -d "client" ] && [ -f "client/package.json" ]; then
+            if [ ! -d "client/node_modules" ]; then
+                echo "Installing client dependencies..." >&2
+                cd client && npm install >&2 && cd .. || { echo "❌ Failed to install client dependencies" >&2; exit 1; }
+            fi
+        elif [ -d "frontend" ] && [ -f "frontend/package.json" ]; then
+            if [ ! -d "frontend/node_modules" ]; then
+                echo "Installing frontend dependencies..." >&2
+                cd frontend && npm install >&2 && cd .. || { echo "❌ Failed to install frontend dependencies" >&2; exit 1; }
+            fi
+        fi
+    fi
+}

klaudbiusz/cli/eval/trpc/test.sh

@@ -4,6 +4,12 @@ set -e
 # tRPC template test script
 # Runs tests using root-level npm test command
 
+# Source common functions
+source "$(dirname "$0")/common.sh"
+
+# Install dependencies if needed
+install_dependencies
+
 # Check if package.json exists
 if [ ! -f "package.json" ]; then
     echo "❌ Error: No package.json found" >&2

klaudbiusz/cli/eval/trpc/typecheck.sh

@@ -4,6 +4,12 @@ set -e
 # tRPC template typecheck script
 # Runs TypeScript type checking separately for server/ and client/
 
+# Source common functions
+source "$(dirname "$0")/common.sh"
+
+# Install dependencies if needed
+install_dependencies
+
 # Check server directory
 if [ -d "server" ] && [ -f "server/tsconfig.json" ]; then
     echo "Checking server types..." >&2

klaudbiusz/cli/evaluate_app.py

@@ -429,14 +429,13 @@ def check_type_safety(app_dir: Path, template: str = "unknown") -> bool:
     """
     print("  [3/7] Checking type safety...")
 
-    # Determine which template script to use
-    dockerfile = app_dir / "Dockerfile"
-    if dockerfile.exists():
-        script_dir = "docker"
-    elif template == "dbx-sdk":
+    # Determine which template script to use (prefer template-specific over docker)
+    if template == "dbx-sdk":
         script_dir = "dbx-sdk"
     elif template == "trpc":
         script_dir = "trpc"
+    elif (app_dir / "Dockerfile").exists():
+        script_dir = "docker"
     else:
         # Unknown template - fail
         print(f"  ⚠️  Unknown template: {template}")
@@ -465,14 +464,13 @@ def check_tests_pass(app_dir: Path, template: str = "unknown") -> tuple[bool, fl
     """
     print("  [4/7] Checking tests pass...")
 
-    # Determine which template script to use
-    dockerfile = app_dir / "Dockerfile"
-    if dockerfile.exists():
-        script_dir = "docker"
-    elif template == "dbx-sdk":
+    # Determine which template script to use (prefer template-specific over docker)
+    if template == "dbx-sdk":
         script_dir = "dbx-sdk"
     elif template == "trpc":
         script_dir = "trpc"
+    elif (app_dir / "Dockerfile").exists():
+        script_dir = "docker"
     else:
         # Unknown template - fail
         return False, 0.0, False