pass object by pointers

Author: leandroberetta

pkg/pipeline/transform/kubernetes/datasource/datasource.go

@@ -13,7 +13,7 @@ type Datasource struct {
 
 func NewInformerDatasource(kubeconfig string, infConfig *informers.Config, opMetrics *operational.Metrics) (*Datasource, error) {
 	inf := &informers.Informers{}
-	if err := inf.InitFromConfig(kubeconfig, *infConfig, opMetrics); err != nil {
+	if err := inf.InitFromConfig(kubeconfig, infConfig, opMetrics); err != nil {
 		return nil, err
 	}
 	return &Datasource{Informers: inf}, nil

pkg/pipeline/transform/kubernetes/enrich.go

@@ -17,13 +17,13 @@ var infConfig informers.Config
 
 // For testing
 func MockInformers() {
-	infConfig = informers.NewConfig(api.NetworkTransformKubeConfig{})
+	infConfig = informers.NewConfig(&api.NetworkTransformKubeConfig{})
 	ds = &datasource.Datasource{Informers: informers.NewInformersMock()}
 }
 
 func InitInformerDatasource(config *api.NetworkTransformKubeConfig, opMetrics *operational.Metrics) error {
 	var err error
-	infConfig = informers.NewConfig(*config)
+	infConfig = informers.NewConfig(config)
 	if ds == nil {
 		ds, err = datasource.NewInformerDatasource(config.ConfigPath, &infConfig, opMetrics)
 	}

pkg/pipeline/transform/kubernetes/informers/config.go

@@ -22,7 +22,7 @@ type Config struct {
 	trackedKinds      []string
 }
 
-func NewConfig(cfg api.NetworkTransformKubeConfig) Config {
+func NewConfig(cfg *api.NetworkTransformKubeConfig) Config {
 	c := Config{
 		managedCNI:        cfg.ManagedCNI,
 		secondaryNetworks: cfg.SecondaryNetworks,

pkg/pipeline/transform/kubernetes/informers/informers-mock.go

@@ -36,7 +36,7 @@ func NewInformersMock() *Mock {
 	return inf
 }
 
-func (o *Mock) InitFromConfig(kubeconfig string, infConfig Config, opMetrics *operational.Metrics) error {
+func (o *Mock) InitFromConfig(kubeconfig string, infConfig *Config, opMetrics *operational.Metrics) error {
 	args := o.Called(kubeconfig, infConfig, opMetrics)
 	return args.Error(0)
 }
@@ -249,15 +249,15 @@ type FakeInformers struct {
 }
 
 func SetupStubs(ipInfo, customKeysInfo, nodes map[string]*model.ResourceMetaData) (Config, *FakeInformers) {
-	cfg := NewConfig(api.NetworkTransformKubeConfig{SecondaryNetworks: secondaryNetConfig})
+	cfg := NewConfig(&api.NetworkTransformKubeConfig{SecondaryNetworks: secondaryNetConfig})
 	return cfg, &FakeInformers{
 		ipInfo:         ipInfo,
 		customKeysInfo: customKeysInfo,
 		nodes:          nodes,
 	}
 }
 
-func (f *FakeInformers) InitFromConfig(_ string, _ Config, _ *operational.Metrics) error {
+func (f *FakeInformers) InitFromConfig(_ string, _ *Config, _ *operational.Metrics) error {
 	return nil
 }
 

pkg/pipeline/transform/kubernetes/informers/informers.go

@@ -316,7 +316,7 @@ func (k *Informers) getHostName(hostIP string) string {
 	return ""
 }
 
-func (k *Informers) initNodeInformer(informerFactory inf.SharedInformerFactory, cfg Config) error {
+func (k *Informers) initNodeInformer(informerFactory inf.SharedInformerFactory, cfg *Config) error {
 	nodes := informerFactory.Core().V1().Nodes().Informer()
 	// Transform any *v1.Node instance into a *Info instance to save space
 	// in the informer's cache
@@ -368,7 +368,7 @@ func (k *Informers) initNodeInformer(informerFactory inf.SharedInformerFactory,
 	return nil
 }
 
-func (k *Informers) initPodInformer(informerFactory inf.SharedInformerFactory, cfg Config, dynClient *dynamic.DynamicClient) error {
+func (k *Informers) initPodInformer(informerFactory inf.SharedInformerFactory, cfg *Config, dynClient *dynamic.DynamicClient) error {
 	pods := informerFactory.Core().V1().Pods().Informer()
 	// Transform any *v1.Pod instance into a *Info instance to save space
 	// in the informer's cache
@@ -582,9 +582,9 @@ func (k *Informers) initVirtualMachineInformer(informerFactory metadatainformer.
 	return nil
 }
 
-func (k *Informers) InitFromConfig(kubeconfig string, infConfig Config, opMetrics *operational.Metrics) error {
+func (k *Informers) InitFromConfig(kubeconfig string, infConfig *Config, opMetrics *operational.Metrics) error {
 	// Initialization variables
-	k.config = infConfig
+	k.config = *infConfig
 	k.stopChan = make(chan struct{})
 	k.mdStopChan = make(chan struct{})
 
@@ -617,7 +617,7 @@ func (k *Informers) InitFromConfig(kubeconfig string, infConfig Config, opMetric
 	return nil
 }
 
-func (k *Informers) initInformers(client kubernetes.Interface, metaClient metadata.Interface, dynClient *dynamic.DynamicClient, cfg Config) error {
+func (k *Informers) initInformers(client kubernetes.Interface, metaClient metadata.Interface, dynClient *dynamic.DynamicClient, cfg *Config) error {
 	informerFactory := inf.NewSharedInformerFactory(client, syncTime)
 	metadataInformerFactory := metadatainformer.NewSharedInformerFactory(metaClient, syncTime)
 	err := k.initNodeInformer(informerFactory, cfg)