New timeFormat parameter: "ISO8601" #377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Throw an error if `options.connection` is defined. Retain the `options` for subsequent calls to `r.connect` when trying to reconnect. The following options were not being used in reconnections: - username - password - pingInterval - timeout - ssl
There was a missing for-loop that caused a ReferenceError to be thrown.
Author
Author
|
All tests passed but it failed due to timeout? wtf |
|
LGTM. Can you retrigger the tests to do a successful run? |
Reconnect using all options
…ptions Remove unused properties from `pool.options.connection`
Fix pool matching when a server has no assigned pool
Add cursor.asyncIterator()
Linked list
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue #376 and is a desired feature in RethinkDB: rethinkdb/rethinkdb#5061
I had to add luxon as a dependency for this one, but I think it is doable.