Skip to content

Conversation

@ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 1, 2025

☑️ Resolves

  • Browsers decided that in German numbers should not be shortened like 2048 should be 2048 instead of 2K in English
  • This PR uses English style instead of German to shorten the number in German
  • ⚠️ Same problem in Italian. Shall we do the same?
Before After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@ShGKme ShGKme added this to the 9.0.1 milestone Oct 1, 2025
@ShGKme ShGKme requested review from a team, jancborchardt and marcoambrosini October 1, 2025 21:39
@ShGKme ShGKme self-assigned this Oct 1, 2025
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews labels Oct 1, 2025
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 1, 2025

/backport to stable8

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 2, 2025

@marcoambrosini For Italian we keep it in full form, correct?

@szaimen
Copy link
Contributor

szaimen commented Oct 2, 2025

Honestly, I am not sure about this change. Using 2K is very uncommon in german afaik...

@kra-mo
Copy link
Member

kra-mo commented Oct 2, 2025

Isn't there a library for this with already localized short forms? I understand that it would be an extra dependency but I don't feel too great about doing this for every language manually, especially because the thousands are not the only thing that is usually shortened.

@kra-mo
Copy link
Member

kra-mo commented Oct 2, 2025

I'm sure you've seen this one before :D

@marcoambrosini
Copy link
Contributor

Correct for Italian @ShGKme

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 2, 2025

@kra-mo we don't do it manually for every language. We are using the native Intl formatter.

The problem is that the default formatter doesn't shorten thousands in German and Italian languages, unlike all the other languages. And as far as I know, it is on purpose.

So the proposal is to use English style shortening for German (and, maybe, Italian).

@kra-mo
Copy link
Member

kra-mo commented Oct 2, 2025

@kra-mo we don't do it manually for every language. We are using the native Intl formatter.

The problem is that the default formatter doesn't shorten thousands in German and Italian languages, unlike all the other languages. And as far as I know, it is on purpose.

So the proposal is to use English style shortening for German (and, maybe, Italian).

Ah, I see. Maybe ask upstream? Otherwise, my hands are off then :)

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 2, 2025

Maybe ask upstream?

Upstream is Google, Microsoft, Apple and Mozilla with their browsers, so, I'm unsure if it is an option :)

The question is: do we want to shorten numbers in German (and Italian) or not.

Copy link
Contributor

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be correct in German (and in English as well?) it would have to be a lowercase "k", so "2k".

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 6, 2025

(and in English as well?) it would have to be a lowercase "k", so "2k"

@jancborchardt It uses native browsers formatter, not a custom one. So in English it is K uppercase as defined by the browser. Like in other places (likes/views on social media, YouTube and etc.).

As we are making a custom option for German anyway, I can make it lowercase, but could you provide complete rules in this case? For example, is it always lower case, or only for k.

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 6, 2025

Note: counter in EN and DE on YouTube. Indeed, it is not shortened with K, as @szaimen noticed.

image image

@jancborchardt
Copy link
Contributor

So in German it is not super common, but if we need a shortened one, "2k" is definitely possible.
A more common one would be "2 Tsd." but that doesn’t really shorten it. For million the common one is "2 Mio.", which would shorten it better.

The German page for info on the "thousand" shortening: https://de.wikipedia.org/wiki/Tausend#Gebr%C3%A4uchliche_Abk%C3%BCrzungen_und_Synonyme

@jancborchardt
Copy link
Contributor

What we could also do is then simply not shorten the thousands if we think it’s fine. What happens above certain limits like with 10k, 100k etc? At what point does it shorten at all?

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 6, 2025

What we could also do is then simply not shorten the thousands if we think it’s fine. What happens above certain limits like with 10k, 100k etc? At what point does it shorten at all?

Starting 1000000 formatted to 1 Mio.

@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 6, 2025

What we could also do is then simply not shorten the thousands if we think it’s fine.

That is the current state

@susnux
Copy link
Contributor

susnux commented Oct 6, 2025

I think this is then probably fine in German.
While for me and likely many others "2 k" would be ok and understandable, the official shortenings should be "Tsd." which is basically not shorter and only useful when writing numbers as text.

@susnux susnux modified the milestones: 9.0.1, 9.0.2 Oct 6, 2025
@susnux susnux removed this from the 9.0.2 milestone Oct 14, 2025
@susnux susnux added this to the 9.1.0 milestone Oct 14, 2025
@susnux susnux modified the milestones: 9.1.0, 9.2.0 Nov 4, 2025
@ShGKme ShGKme modified the milestones: 9.2.0, 9.3.0 Nov 14, 2025
@susnux susnux modified the milestones: 9.3.0, 9.3.1 Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews backport-request bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants