-
Notifications
You must be signed in to change notification settings - Fork 95
fix(NcCounterBubble): also shorten in German #7589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Grigorii K. Shartsev <[email protected]>
|
/backport to stable8 |
|
@marcoambrosini For Italian we keep it in full form, correct? |
|
Honestly, I am not sure about this change. Using 2K is very uncommon in german afaik... |
|
Isn't there a library for this with already localized short forms? I understand that it would be an extra dependency but I don't feel too great about doing this for every language manually, especially because the thousands are not the only thing that is usually shortened. |
|
I'm sure you've seen this one before :D |
|
Correct for Italian @ShGKme |
|
@kra-mo we don't do it manually for every language. We are using the native Intl formatter. The problem is that the default formatter doesn't shorten thousands in German and Italian languages, unlike all the other languages. And as far as I know, it is on purpose. So the proposal is to use English style shortening for German (and, maybe, Italian). |
Ah, I see. Maybe ask upstream? Otherwise, my hands are off then :) |
Upstream is Google, Microsoft, Apple and Mozilla with their browsers, so, I'm unsure if it is an option :) The question is: do we want to shorten numbers in German (and Italian) or not. |
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be correct in German (and in English as well?) it would have to be a lowercase "k", so "2k".
@jancborchardt It uses native browsers formatter, not a custom one. So in English it is K uppercase as defined by the browser. Like in other places (likes/views on social media, YouTube and etc.). As we are making a custom option for German anyway, I can make it lowercase, but could you provide complete rules in this case? For example, is it always lower case, or only for |
|
Note: counter in EN and DE on YouTube. Indeed, it is not shortened with K, as @szaimen noticed.
|
|
So in German it is not super common, but if we need a shortened one, "2k" is definitely possible. The German page for info on the "thousand" shortening: https://de.wikipedia.org/wiki/Tausend#Gebr%C3%A4uchliche_Abk%C3%BCrzungen_und_Synonyme |
|
What we could also do is then simply not shorten the thousands if we think it’s fine. What happens above certain limits like with 10k, 100k etc? At what point does it shorten at all? |
Starting |
That is the current state |
|
I think this is then probably fine in German. |


☑️ Resolves
2048should be2048instead of2Kin English🏁 Checklist
stable8for maintained Vue 2 version or not applicable