Fix remaining tests

Author: niccokunzmann

docs/changelog.md

@@ -15,6 +15,10 @@ We use [Semantic Versioning](https://semver.org)
 
 To avoid breaking changes breaking your code, install this library fixed to a specific version.
 
+## v3.8.0
+
+- Fix: Invalid events and todos that swapped start and end are now calculated with start before end. See [Issue 132](https://github.com/niccokunzmann/python-recurring-ical-events/issues/132).
+
 ## v3.7.1
 
 - Fix: RECURENCE-ID is now not identical to DTSTART. See [Issue 243](https://github.com/niccokunzmann/python-recurring-ical-events/issues/243).

pyproject.toml

@@ -128,6 +128,7 @@ extend-safe-fixes = [
     "PT012",  # pytest.raises() block should contain a single simple statement
     "PT015",  # Assertion always fails, replace with pytest.fail()
     "T201",   # print found
+    "N803",   # ZoneInfo should be lowercase
 ]
 "example.py" = [
     "T201", # print found

recurring_ical_events/test/conftest.py

@@ -125,7 +125,7 @@ def tzp(request):
 
 
 # for parametrizing fixtures, see https://docs.pytest.org/en/latest/fixture.html#parametrizing-fixtures
-@pytest.fixture(params=[Calendars, ReversedCalendars], scope="module")
+@pytest.fixture(params=[Calendars, ReversedCalendars])
 def calendars(request, tzp) -> ICSCalendars:
     """The calendars we can use in the tests."""
     return request.param(tzp)

recurring_ical_events/test/test_issue_132_swapped_start_and_end.py

@@ -2,6 +2,8 @@
 
 from datetime import datetime
 
+import pytest
+
 
 def test_event_case(calendars):
     """Test an event with swapped start and end."""
@@ -19,7 +21,17 @@ def test_todo_case(calendars):
     assert todo.end.replace(tzinfo=None) == datetime(2023, 12, 18, 23, 45)
 
 
-def test_old_example_works_now(calendars):
+@pytest.mark.parametrize("skip_invalid", [True, False])
+def test_old_example_works_now(calendars, ZoneInfo, skip_invalid):
     """The old tests works now."""
+    calendars.skip_bad_series = skip_invalid
     events = calendars.end_before_start_event.at(2019)
+    print(list(calendars.end_before_start_event.all()))
     assert len(events) == 1
+    event = events[0]
+    assert event.start == datetime(
+        2019, 3, 4, 8, tzinfo=ZoneInfo("Europe/Berlin")
+    )  # 20190304T080000
+    assert event.end == datetime(
+        2019, 3, 4, 8, 30, tzinfo=ZoneInfo("Europe/Berlin")
+    )  # 20190304T080300

recurring_ical_events/test/test_skip_bad_events.py

@@ -9,7 +9,6 @@
 @pytest.mark.parametrize(
     ("calendar_name", "start", "end"),
     [
-        ("end_before_start_event", date(2019, 1, 1), date(2019, 12, 31)),
         ("bad_rrule_missing_until_event", date(2019, 3, 1), date(2019, 12, 31)),
     ],
 )