Skip to content

ENH: Validate PET data objects' attributes at instantiation #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jhlegarreta wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

ENH: Validate PET data objects' attributes at instantiation #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40b7add
ENH: Validate PET data objects' attributes at instantiation
jhlegarreta Dec 3, 2025
ecf6bab
WIP: Override `to_nifti`
jhlegarreta Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/notebooks/pet_motion_estimation.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"from os import getenv\n",
"from pathlib import Path\n",
"\n",
"from nifreeze.data.pet import PET\n",
"from nifreeze.data.pet import from_nii\n",
"\n",
"# Install test data from gin.g-node.org:\n",
"# $ datalad install -g https://gin.g-node.org/nipreps-data/tests-nifreeze.git\n",
Expand All @@ -29,7 +29,7 @@
" DATA_PATH / \"pet_data\" / \"sub-02\" / \"ses-baseline\" / \"pet\" / \"sub-02_ses-baseline_pet.json\"\n",
")\n",
"\n",
"pet_dataset = PET.load(pet_file, json_file)"
"pet_dataset = from_nii(pet_file, temporal_file=json_file)"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ classifiers = [
license = "Apache-2.0"
requires-python = ">=3.10"
dependencies = [
"attrs>=20.1.0",
"attrs>=24.1.0",
"dipy>=1.5.0",
"joblib",
"nipype>=1.5.1,<2.0",
Expand Down
2 changes: 1 addition & 1 deletion src/nifreeze/data/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def load(
from nifreeze.data.dmri import from_nii as dmri_from_nii

return dmri_from_nii(filename, brainmask_file=brainmask_file, **kwargs)
elif {"frame_time", "frame_duration"} & set(kwargs):
elif {"temporal_file"} & set(kwargs):
from nifreeze.data.pet import from_nii as pet_from_nii

return pet_from_nii(filename, brainmask_file=brainmask_file, **kwargs)
Expand Down
Loading
Loading