Skip to content

Commit 5203f72

Browse files
committed
Remove unused variables from pushimage script
1 parent 85f1458 commit 5203f72

File tree

2 files changed

+1
-24
lines changed

2 files changed

+1
-24
lines changed

make/photon/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ TIMESTAMP=$(shell date +"%Y%m%d")
2020
DOCKERCMD=$(shell which docker)
2121
DOCKERBUILD=$(DOCKERCMD) build --no-cache --network=$(DOCKERNETWORK)
2222
DOCKERBUILD_WITH_PULL_PARA=$(DOCKERBUILD) --pull=false
23+
2324
DOCKERRMIMAGE=$(DOCKERCMD) rmi
2425
DOCKERIMAGES=$(DOCKERCMD) images
2526
IMAGENAMESPACE=harbor.nirvati.org/registry

make/pushimage.sh

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -56,27 +56,6 @@ type_exists() {
5656
return 1
5757
}
5858

59-
# Check variables
60-
if [ -z $1 ]; then
61-
error "Please set the 'image' variable"
62-
exit 1
63-
fi
64-
65-
if [ -z $2 ]; then
66-
error "Please set the 'username' variable"
67-
exit 1
68-
fi
69-
70-
if [ -z $3 ]; then
71-
error "Please set the 'password' variable"
72-
exit 1
73-
fi
74-
75-
if [ -z $4 ]; then
76-
info "Using default registry server (dockerhub)."
77-
fi
78-
79-
8059
# Check Docker is installed
8160
if ! type_exists 'docker'; then
8261
error "Docker is not installed."
@@ -86,9 +65,6 @@ fi
8665

8766
# Variables
8867
IMAGE="$1"
89-
USERNAME="$2"
90-
PASSWORD="$3"
91-
REGISTRY="$4"
9268
PULL_BASE_FROM_DOCKERHUB="$5"
9369

9470
set -e

0 commit comments

Comments
 (0)