Skip to content

Fix altair plots #2108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix altair plots #2108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53e0acd
chore: use named export for markdown
aminya May 27, 2021
690be34
fix: update @ntereact/transform-vega and @nteract/outputs
aminya May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/components/inspector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { observer } from "mobx-react";
import { RichMedia, Media } from "@nteract/outputs";
import { INSPECTOR_URI } from "../utils";
import type Kernel from "../kernel";
import Markdown from "./result-view/markdown";
import { Markdown } from "./result-view/markdown";
type Props = {
store: {
kernel: Kernel | null | undefined;
Expand Down
2 changes: 1 addition & 1 deletion lib/components/result-view/display.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {
Vega4,
Vega5,
} from "@nteract/transform-vega";
import Markdown from "./markdown";
import { Markdown } from "./markdown";
// All supported media types for output go here
export const supportedMediaTypes = (
<RichMedia>
Copy link
Member Author

@aminya aminya May 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I am unfamiliar with @nteract/transform-vega and @nteract/outputs, it appears that examples/vega_datasets-altair.py does not plot anything because of this particular part of the code.

cc: @captainsafia

Expand Down
1 change: 0 additions & 1 deletion lib/components/result-view/markdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,3 @@ export class Markdown extends React.PureComponent<Props> {
);
}
}
export default Markdown;
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,20 +57,20 @@
"atom": ">=1.28.0 <2.0.0"
},
"dependencies": {
"@aminya/jmp": "^2.0.9",
"@aminya/xmlhttprequest": "^1.8.2",
"@babel/runtime-corejs2": "^7.0.0",
"@jupyterlab/services": "^0.52.0",
"@nteract/commutable": "^7.1.4",
"@nteract/markdown": "^4.5.1",
"@nteract/mathjax": "^4.0.2",
"@nteract/outputs": "^3.0.0",
"@nteract/outputs": "^3.0.11",
"@nteract/plotly": "^1.48.3",
"@nteract/transform-vega": "^7.0.0",
"@nteract/transform-vega": "^7.0.10",
"anser": "^2.0.1",
"atom-select-list": "^0.7.0",
"escape-carriage": "^1.2.0",
"escape-string-regexp": "^4.0.0",
"@aminya/jmp": "^2.0.9",
"kernelspecs": "^2.0.0",
"lodash": "^4.14.0",
"mathjax-electron": "^3.0.0",
Expand Down