CLI: cosmetic improvements

Author: oleg-shilo

src/cscs/Utils/CoreExtensions.cs

@@ -467,12 +467,15 @@ internal static string[] RetreiveProcessPathExtraDirs(this Process p)
             return dirs?.Split(';') ?? new string[0];
         }
 
-        internal static void AddToSystemPath(this string[] dirs)
+        internal static void AddToSystemPath(this IEnumerable<string> dirs)
         {
             if (dirs.Any())
             {
                 var newPathDirs = dirs
                     .Where(x => x.HasText())
+#if !class_lib
+                    .Except(Settings.PseudoDirItems)
+#endif
                     .Select(x => x);
 
                 var currentPath = Environment.GetEnvironmentVariable("PATH").Split(';').Where(x => x.HasText());

src/cscs/Utils/Utils.cs

@@ -1743,7 +1743,6 @@ static public bool IsOutOfDate(string script, string assembly)
                 depInfo.items
                     .Where(x => x.IsDir)
                     .Select(x => x.file.Substring("dir:".Length))
-                    .ToArray()
                     .AddToSystemPath();
 
                 return false;

src/cscs/csscript.cs

@@ -1012,8 +1012,7 @@ void ExecuteImpl()
                         // add searchDirs to PATH to support search path for native dlls
                         // need to do this before compilation or execution
 
-                        options.searchDirs.Except(Settings.PseudoDirItems).ToArray()
-                                          .AddToSystemPath();
+                        options.searchDirs.AddToSystemPath();
 
                         // --- COMPILE ---
                         if (options.buildExecutable || !options.useCompiled || (options.useCompiled && assemblyFileName == null) || options.forceCompile)
@@ -1067,7 +1066,7 @@ void ExecuteImpl()
 
                                     var pureCompilerTime = (compilationTime - initializationTime);
 
-                                    // May need the higher precision timing in teh future so keeping it
+                                    // May need the higher precision timing in the future so keeping it
                                     // TimeSpan compilationOverheadTime = default;
                                     // if (Profiler.has("compiler"))
                                     // {
@@ -1153,7 +1152,7 @@ void ExecuteImpl()
                                     }
                                 }
 
-                                options.searchDirs.AddToSystemPath();
+                                options.searchDirs.Except(Settings.PseudoDirItems).AddToSystemPath();
                                 // Process.GetCurrentProcess().RetreiveProcessPathExtraDirs().AddToSystemPath();
 
                                 if (options.useCompiled)