-
Notifications
You must be signed in to change notification settings - Fork 200
Description
Most of the grpc converter tests were updated to ensure correct conversions to/from protobuf. We have since made improvements to fixture generators that produce more complete test data, which should make these test more robust.
Review all converters with https://github.com/onflow/flow-go/tree/master/engine/common/rpc/convert. Ensure each method has a test that validates converting to and from protobuf returns an identical object. If the object has a hash/ID use the method to ensure the objects are cryptographically identical.
Update tests to use the fixtures suite to generate complete random objects, which should exercise all of the pathways in the converters.
https://github.com/onflow/flow-go/tree/master/utils/unittest/fixtures
if new fixtures are needed, it's OK to add them. make sure to follow the existing convention from other generators.