-
Notifications
You must be signed in to change notification settings - Fork 200
Remove scheduled transactions feature flag #8142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Remove scheduled transactions feature flag #8142
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
…hub.com/devbugging/flow-go into gregor/remove-feature-flag-scheduled-tx
…hub.com/devbugging/flow-go into gregor/remove-feature-flag-scheduled-tx
| ExecutionReceipts: node.Storage.Receipts, | ||
| ExecutionResults: node.Storage.Results, | ||
| TxResultErrorMessages: builder.transactionResultErrorMessages, // might be nil | ||
| ScheduledTransactions: builder.scheduledTransactions, // might be nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may still be nil if indexing is not enabled
| } | ||
|
|
||
| // check if it's a scheduled transaction | ||
| if t.scheduledTransactions != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still needed. we only index scheduled tx when execution state indexing is also enabled
Remove the scheduled transactions feature flag, as it is no longer needed and we can disable scheduled transactions on-chain via the smart contract.