Optimize access integration tests runtime #8190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…2, cohort3, cohort4
Contributor
UlyanaAndrukhiv
left a comment
UlyanaAndrukhiv
left a comment
There was a problem hiding this comment.
I left a few comments suggesting areas where we might be able to simplify some tests. I haven’t looked at every detail, so these are just observations based on what I’ve seen so far.
- cohort1/access_api_test wrapped each test calls in test suite into subtests with descriptive names using t.Run
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
peterargue
approved these changes
Nov 28, 2025
Contributor
peterargue
left a comment
peterargue
left a comment
There was a problem hiding this comment.
added a few small comments, but otherwise looks good
integration/tests/access/cohort2/observer_indexer_enabled_test.go
Outdated
Show resolved
Hide resolved
UlyanaAndrukhiv
approved these changes
Dec 1, 2025
…s-integration-tests-runtime
peterargue
deleted the
taras/7157-optimize-access-integration-tests-runtime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7157
Changes: