Skip to content

Illia malachyn/new execution data tests #8200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: feature/optimistic-sync
Choose a base branch
from
Draft

Illia malachyn/new execution data tests #8200

wants to merge 3 commits into from

Conversation

@illia-malachyn
Copy link
Contributor

@illia-malachyn illia-malachyn commented Nov 27, 2025 •
edited
Loading

Closes #8059

Changes:

  • no more separate test for a streaming from a spork root block. Any test does it!
  • result info provider extended with new functionality: it recognizes execution forks now!
  • removed index from execution data tracker

@illia-malachyn illia-malachyn changed the base branch from master to feature/optimistic-sync November 27, 2025 19:10
@illia-malachyn
Copy link
Contributor Author

illia-malachyn commented Nov 27, 2025

@AndriiDiachuk

@illia-malachyn
update execution result provider to handle execution forks
4a7ea31
@illia-malachyn
Add criteria to subscribe endpoints in execution data backend
f9af1be 
Refactored execution data tracker. I completely
removed the indexer dependency from it.

Response handler in execution data backend was
refactored in a way it supports criteria and
execution forks. More work to be done on this but
this is the first step forward.
@illia-malachyn illia-malachyn force-pushed the illia-malachyn/new-execution-data-tests branch from d0c8497 to 661a1d5 Compare November 28, 2025 11:19
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 28.35821% with 96 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...executiondatasync/optimistic_sync/mock/pipeline.go 0.00% 31 Missing ⚠️
...utiondatasync/optimistic_sync/mock/core_factory.go 0.00% 16 Missing ⚠️
...ndatasync/optimistic_sync/mock/pipeline_factory.go 0.00% 16 Missing ⚠️
...nc/optimistic_sync/mock/pipeline_state_provider.go 0.00% 15 Missing ⚠️
.../optimistic_sync/execution_result/info_provider.go 84.44% 6 Missing and 1 partial ⚠️
...nc/optimistic_sync/mock/pipeline_state_consumer.go 0.00% 7 Missing ⚠️
.../optimistic_sync/execution_result_info_provider.go 0.00% 2 Missing ⚠️
cmd/access/node_builder/access_node_builder.go 0.00% 1 Missing ⚠️
cmd/observer/node_builder/observer_builder.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@illia-malachyn illia-malachyn force-pushed the illia-malachyn/new-execution-data-tests branch from 661a1d5 to e0cbb11 Compare November 28, 2025 11:56
@illia-malachyn illia-malachyn force-pushed the illia-malachyn/new-execution-data-tests branch from e0cbb11 to 5ecb6ab Compare November 28, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@illia-malachyn @codecov-commenter