fix url casing in var names

beeme1mr · beeme1mr · commit dd7801aa8d42 · 2025-11-07T17:27:16.000-05:00
Signed-off-by: Michael Beemer &lt;beeme1mr@users.noreply.github.com&gt;
diff --git a/internal/cmd/init.go b/internal/cmd/init.go
@@ -84,40 +84,40 @@ func handleManifestCreation(manifestPath string, override bool) error {
 	return nil
 }
 
-func handleConfigFile(providerUrl string, override bool) error {
+func handleConfigFile(providerURL string, override bool) error {
 	configPath := ".openfeature.yaml"
 	configExists, err := filesystem.Exists(configPath)
 	if err != nil {
 		return fmt.Errorf("failed to check if config file exists: %w", err)
 	}
 
 	if !configExists {
-		return writeConfigFile(providerUrl, "Creating .openfeature.yaml configuration file")
+		return writeConfigFile(providerURL, "Creating .openfeature.yaml configuration file")
 	}
 
-	if providerUrl == "" {
+	if providerURL == "" {
 		return nil // no config to write
 	}
 
 	if override {
-		return writeConfigFile(providerUrl, "Updating provider URL in .openfeature.yaml")
+		return writeConfigFile(providerURL, "Updating provider URL in .openfeature.yaml")
 	}
 
 	shouldOverride, err := confirmOverride("configuration file", configPath)
 	if err != nil {
 		return fmt.Errorf("failed to get user confirmation: %w", err)
 	}
 	if shouldOverride {
-		return writeConfigFile(providerUrl, "Updating provider URL in .openfeature.yaml")
+		return writeConfigFile(providerURL, "Updating provider URL in .openfeature.yaml")
 	}
 
 	logger.Default.Info("Configuration file was not modified.")
 	return nil
 }
 
-func writeConfigFile(providerUrl, message string) error {
-	pterm.Info.Println(message, pterm.LightWhite(providerUrl))
-	template := getConfigTemplate(providerUrl)
+func writeConfigFile(providerURL, message string) error {
+	pterm.Info.Println(message, pterm.LightWhite(providerURL))
+	template := getConfigTemplate(providerURL)
 	return filesystem.WriteFile(".openfeature.yaml", []byte(template))
 }
 
@@ -180,12 +180,12 @@ const configTemplateText = `# OpenFeature CLI Configuration
 #     package-name: "com.example.openfeature"
 `
 
-func getConfigTemplate(providerUrl string) string {
+func getConfigTemplate(providerURL string) string {
 	tmpl := template.Must(template.New("config").Parse(configTemplateText))
 
 	data := configTemplateData{
-		ProviderURL:    providerUrl,
-		HasProviderURL: providerUrl != "",
+		ProviderURL:    providerURL,
+		HasProviderURL: providerURL != "",
 	}
 
 	var buf bytes.Buffer
diff --git a/internal/cmd/pull.go b/internal/cmd/pull.go
@@ -42,17 +42,17 @@ Why pull from a remote source:
 			return initializeConfig(cmd, "pull")
 		},
 		RunE: func(cmd *cobra.Command, args []string) error {
-			providerUrl := config.GetFlagSourceUrl(cmd)
+			providerURL := config.GetFlagSourceUrl(cmd)
 			manifestPath := config.GetManifestPath(cmd)
 			authToken := config.GetAuthToken(cmd)
 			noPrompt := config.GetNoPrompt(cmd)
 
-			if providerUrl == "" {
+			if providerURL == "" {
 				return fmt.Errorf("provider URL not set in config. Please provide --provider-url or set 'provider' in .openfeature.yaml")
 			}
 
 			// fetch the flags from the remote source
-			parsedURL, err := url.Parse(providerUrl)
+			parsedURL, err := url.Parse(providerURL)
 			if err != nil {
 				return fmt.Errorf("invalid URL: %w", err)
 			}
@@ -69,14 +69,14 @@ Why pull from a remote source:
 				urlContainsAFileExtension := manifest.URLLooksLikeAFile(parsedURL.String())
 				if urlContainsAFileExtension {
 					// Use direct HTTP requests for pulling flags from file-like URLs
-					loadedFlags, err := manifest.LoadFromRemote(providerUrl, authToken)
+					loadedFlags, err := manifest.LoadFromRemote(providerURL, authToken)
 					if err != nil {
 						return fmt.Errorf("error fetching flags from remote source: %w", err)
 					}
 					flags = loadedFlags
 				} else {
 					// Use the sync API client for pulling flags
-					loadedFlags, err := manifest.LoadFromSyncAPI(providerUrl, authToken)
+					loadedFlags, err := manifest.LoadFromSyncAPI(providerURL, authToken)
 					if err != nil {
 						return fmt.Errorf("error fetching flags from remote source: %w", err)
 					}
@@ -101,7 +101,7 @@ Why pull from a remote source:
 				}
 			}
 
-			pterm.Success.Printfln("Successfully fetched flags from %s", providerUrl)
+			pterm.Success.Printfln("Successfully fetched flags from %s", providerURL)
 			if err := manifest.Write(manifestPath, *flags); err != nil {
 				return fmt.Errorf("error writing manifest: %w", err)
 			}
diff --git a/internal/cmd/push.go b/internal/cmd/push.go
@@ -55,18 +55,18 @@ For local file operations, use standard shell commands like cp or mv.`,
 		},
 		RunE: func(cmd *cobra.Command, args []string) error {
 			// Get configuration values
-			providerUrl := config.GetFlagSourceUrl(cmd)
+			providerURL := config.GetFlagSourceUrl(cmd)
 			manifestPath := config.GetManifestPath(cmd)
 			authToken := config.GetAuthToken(cmd)
 			dryRun := config.GetDryRun(cmd)
 
 			// Validate destination URL is provided
-			if providerUrl == "" {
+			if providerURL == "" {
 				return fmt.Errorf("provider URL is required. Please provide --provider-url")
 			}
 
 			// Parse and validate URL
-			parsedURL, err := url.Parse(providerUrl)
+			parsedURL, err := url.Parse(providerURL)
 			if err != nil {
 				return fmt.Errorf("invalid source URL: %w", err)
 			}
@@ -86,13 +86,13 @@ For local file operations, use standard shell commands like cp or mv.`,
 			case "http", "https":
 				// Perform smart push (fetches remote, compares, and creates/updates as needed)
 				// In dry run mode, performs comparison but skips actual API calls
-				result, err := manifest.SaveToRemote(providerUrl, flags, authToken, dryRun)
+				result, err := manifest.SaveToRemote(providerURL, flags, authToken, dryRun)
 				if err != nil {
 					return fmt.Errorf("error pushing flags to remote destination: %w", err)
 				}
 
 				// Display the results
-				displayPushResults(result, providerUrl, dryRun)
+				displayPushResults(result, providerURL, dryRun)
 			default:
 				return fmt.Errorf("unsupported URL scheme: %s. Supported schemes are http:// and https://", parsedURL.Scheme)
 			}
@@ -189,7 +189,7 @@ func displayPushResults(result *sync.PushResult, destination string, dryRun bool
 			fmt.Println()
 
 			// Show flag details
-			flagJSON, _ := json.MarshalIndent(map[string]interface{}{
+			flagJSON, _ := json.MarshalIndent(map[string]any{
 				"type":         flag.Type.String(),
 				"defaultValue": flag.DefaultValue,
 			}, "    ", "  ")

Original file line number	Diff line number	Diff line change
`@@ -84,40 +84,40 @@ func handleManifestCreation(manifestPath string, override bool) error {`
`84`	`84`	`return nil`
`85`	`85`	`}`
`86`	`86`
`87`		`-func handleConfigFile(providerUrl string, override bool) error {`
	`87`	`+func handleConfigFile(providerURL string, override bool) error {`
`88`	`88`	`configPath := ".openfeature.yaml"`
`89`	`89`	`configExists, err := filesystem.Exists(configPath)`
`90`	`90`	`if err != nil {`
`91`	`91`	`return fmt.Errorf("failed to check if config file exists: %w", err)`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`if !configExists {`
`95`		`- return writeConfigFile(providerUrl, "Creating .openfeature.yaml configuration file")`
	`95`	`+ return writeConfigFile(providerURL, "Creating .openfeature.yaml configuration file")`
`96`	`96`	`}`
`97`	`97`
`98`		`- if providerUrl == "" {`
	`98`	`+ if providerURL == "" {`
`99`	`99`	`return nil // no config to write`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`if override {`
`103`		`- return writeConfigFile(providerUrl, "Updating provider URL in .openfeature.yaml")`
	`103`	`+ return writeConfigFile(providerURL, "Updating provider URL in .openfeature.yaml")`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`shouldOverride, err := confirmOverride("configuration file", configPath)`
`107`	`107`	`if err != nil {`
`108`	`108`	`return fmt.Errorf("failed to get user confirmation: %w", err)`
`109`	`109`	`}`
`110`	`110`	`if shouldOverride {`
`111`		`- return writeConfigFile(providerUrl, "Updating provider URL in .openfeature.yaml")`
	`111`	`+ return writeConfigFile(providerURL, "Updating provider URL in .openfeature.yaml")`
`112`	`112`	`}`
`113`	`113`
`114`	`114`	`logger.Default.Info("Configuration file was not modified.")`
`115`	`115`	`return nil`
`116`	`116`	`}`
`117`	`117`
`118`		`-func writeConfigFile(providerUrl, message string) error {`
`119`		`- pterm.Info.Println(message, pterm.LightWhite(providerUrl))`
`120`		`- template := getConfigTemplate(providerUrl)`
	`118`	`+func writeConfigFile(providerURL, message string) error {`
	`119`	`+ pterm.Info.Println(message, pterm.LightWhite(providerURL))`
	`120`	`+ template := getConfigTemplate(providerURL)`
`121`	`121`	`return filesystem.WriteFile(".openfeature.yaml", []byte(template))`
`122`	`122`	`}`
`123`	`123`
@@ -180,12 +180,12 @@ const configTemplateText = `# OpenFeature CLI Configuration
`180`	`180`	`# package-name: "com.example.openfeature"`
`181`	`181`	`
`182`	`182`
`183`		`-func getConfigTemplate(providerUrl string) string {`
	`183`	`+func getConfigTemplate(providerURL string) string {`
`184`	`184`	`tmpl := template.Must(template.New("config").Parse(configTemplateText))`
`185`	`185`
`186`	`186`	`data := configTemplateData{`
`187`		`- ProviderURL: providerUrl,`
`188`		`- HasProviderURL: providerUrl != "",`
	`187`	`+ ProviderURL: providerURL,`
	`188`	`+ HasProviderURL: providerURL != "",`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`var buf bytes.Buffer`