Merge #276

276: Update to Rust/Cargo 1.45+ r=behnam a=behnam

- Fix some compiler warnings.
- Use `std::char::UNICODE_VERSION`, stabilized in Rust 1.4.50.
- Clippy: update the rule control syntax, and fix a few warnings.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/276)
<!-- Reviewable:end -->


Co-authored-by: Behnam Esfahbod <[email protected]>

Author: bors[bot]

.appveyor.yml

@@ -1,4 +1,3 @@
 status = [
-  "continuous-integration/travis-ci/push",
-  "continuous-integration/appveyor/branch"
+  "continuous-integration/travis-ci/push"
 ]

.bors.toml

@@ -7,7 +7,7 @@ rust:
   - nightly
   - beta
   - stable
-  - 1.31.0  # = MIN_RUST_VERSION
+  - 1.45.0  # = MIN_RUST_VERSION
 
 branches:
   except:
@@ -26,23 +26,18 @@ env:
     - RUST_BACKTRACE=full
 
 script:
-  - cargo build --verbose --all
-  - cargo doc   --verbose --all --no-deps
+  - cargo build --verbose --workspace
+  - cargo doc   --verbose --workspace --no-deps
 
-  - cargo test  --verbose --all
-  - cargo test  --verbose --all --features serde
+  - cargo test  --verbose --workspace
 
   #  unic-ucd-normal is used in unic-ucd with non-default feature
   - cargo test  --verbose --manifest-path unic/ucd/normal/Cargo.toml
 
   # == Nightly-only ==
 
   - test "$TRAVIS_RUST_VERSION" != "nightly" ||
-    cargo test  --verbose --all --all-features
-
-  # This takes too long, let's disable for now.
-  - test "$TRAVIS_RUST_VERSION" != "nightly" ||
-    cargo build --benches --verbose --all --features 'bench_it'
+    cargo test  --verbose --workspace --all-features
 
 # TODO: - rustdoc --test README.md -L target/debug -L target/debug/deps
 

.travis.yml

@@ -4,7 +4,7 @@
 
 [![Travis](https://img.shields.io/travis/open-i18n/rust-unic/master.svg?label=Linux%20build)](https://travis-ci.org/open-i18n/rust-unic/)
 [![AppVeyor](https://img.shields.io/appveyor/ci/open-i18n/rust-unic/master.svg?label=Windows%20build)](https://ci.appveyor.com/project/open-i18n/rust-unic)
-[![Rust-1.31.0+](https://img.shields.io/badge/rustc-1.31+-red.svg#MIN_RUST_VERSION)](https://www.rust-lang.org/)
+[![Rust-1.45+](https://img.shields.io/badge/rustc-1.45+-red.svg#MIN_RUST_VERSION)](https://www.rust-lang.org/)
 [![Unicode-10.0.0](https://img.shields.io/badge/unicode-10.0.0-red.svg)](https://www.unicode.org/versions/Unicode10.0.0/)
 [![Release](https://img.shields.io/github/release/open-i18n/rust-unic.svg)](https://github.com/open-i18n/rust-unic/)
 [![Crates.io](https://img.shields.io/crates/v/unic.svg)](https://crates.io/crates/unic/)

README.md

@@ -26,5 +26,3 @@ quickcheck = "0.6"
 maintenance = { status = "actively-developed" }
 is-it-maintained-issue-resolution = { repository = "open-i18n/rust-unic" }
 is-it-maintained-open-issues = { repository = "open-i18n/rust-unic" }
-appveyor = { repository = "open-i18n/rust-unic", branch = "master", service = "github" }
-travis-ci = { repository = "open-i18n/rust-unic", branch = "master" }

apps/cli/Cargo.toml

@@ -12,8 +12,6 @@
 
 //! Command-line tool to list versions of UNIC components.
 
-use unic;
-
 macro_rules! print_component_desc {
     ( $component:tt ) => {
         println!("Component: {}", unic::$component::PKG_DESCRIPTION);

apps/cli/src/bin/unic-versions.rs

@@ -10,8 +10,8 @@
 # option. This file may not be copied, modified, or distributed
 # except according to those terms.
 
-# Since `cargo publish --all` does not exist yet, we use this dumb alternative
-# solution for now.
+# Since `cargo clippy --workspace` does not exist yet, we use this dumb
+# alternative solution for now.
 #
 # Main downside of this approch is that there are separate `target/`
 # directories used for each component, increasing the test and publish process

etc/cargo-clippy-all.sh

@@ -10,8 +10,8 @@
 # option. This file may not be copied, modified, or distributed
 # except according to those terms.
 
-# Since `cargo package --all` does not exist yet, we use this dumb alternative
-# solution for now.
+# Since `cargo package --workspace` does not exist yet, we use this dumb
+# alternative solution for now.
 #
 # Main downside of this approch is that there are separate `target/`
 # directories used for each component, increasing the test and publish process

etc/cargo-package-all.sh

@@ -10,8 +10,8 @@
 # option. This file may not be copied, modified, or distributed
 # except according to those terms.
 
-# Since `cargo publish --all` does not exist yet, we use this dumb alternative
-# solution for now.
+# Since `cargo publish --workspaces` does not exist yet, we use this dumb
+# alternative solution for now.
 #
 # Main downside of this approch is that there are separate `target/`
 # directories used for each component, increasing the test and publish process

etc/cargo-publish-all.sh

@@ -10,8 +10,9 @@
 # option. This file may not be copied, modified, or distributed
 # except according to those terms.
 
-# Since `cargo publish --all` does not exist yet, we use this dumb alternative
-# solution for now.
+# Since `cargo publish --workspace` does not exist yet, we use this dumb
+# alternative solution for now to test all components in their isolated form,
+# before publishing them.
 #
 # Main downside of this approch is that there are separate `target/`
 # directories used for each component, increasing the test and publish process