chore: remove vendor #4201
Draft
chore: remove vendor #4201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sertac Ozercan <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes vendor mode from the Go build process across the project. The changes update build commands to use standard Go module resolution instead of vendored dependencies, and add build cache mounts to improve Docker build performance.
- Removed
-mod vendorflag from allgo build,go test, andgo runcommands - Added BuildKit cache mounts for Go modules and build cache in Dockerfiles
- Updated both production and development build configurations
Reviewed Changes
Copilot reviewed 4 out of 8452 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gator.Dockerfile | Removed vendor mode and added cache mounts for gator binary build |
| Dockerfile | Removed vendor mode and added cache mounts for manager binary build |
| Makefile | Removed vendor mode from test, build, and run targets |
| Tiltfile | Removed vendor mode from development build command |
Contributor
JaydipGabani
left a comment
JaydipGabani
left a comment
There was a problem hiding this comment.
should vendor be added to .gitignore here or as a follow up?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: