[connector/count] Support all attribute types (#43768)

#### Description
The count connector currently implements its own parsing and copying
logic for attributes. This means that attributes with non-supported
types (e.g. booleans) are converted to the empty string.

We replace this custom logic with a more standard `CopyTo` and
`FromRaw`.

#### Testing
All existing tests pass unchanged. There is a new test that asserts
common attribute types (string, int, double, bool) can be copied.

Author: SquidDev

.chloggen/countconnector-any-attr.yaml

@@ -0,0 +1,27 @@
+# Use this changelog template to create an entry for release notes.
+
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: enhancement
+
+# The name of the component, or a single word describing the area of concern, (e.g. receiver/filelog)
+component: connector/count
+
+# A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Support all attribute types in the count connector
+
+# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
+issues: [43768]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:
+
+# If your change doesn't affect end users or the exported elements of any package,
+# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
+# Optional: The change log or logs in which this entry should be included.
+# e.g. '[user]' or '[user, api]'
+# Include 'user' if the change is relevant to end users.
+# Include 'api' if there is a change to a library API.
+# Default: '[user]'
+change_logs: [user]

connector/countconnector/config.go

@@ -9,6 +9,7 @@ import (
 
 	"go.opentelemetry.io/collector/component"
 	"go.opentelemetry.io/collector/confmap"
+	"go.opentelemetry.io/collector/pdata/pcommon"
 	"go.uber.org/zap"
 
 	"github.com/open-telemetry/opentelemetry-collector-contrib/internal/filter/filterottl"
@@ -134,10 +135,16 @@ func (c *Config) Validate() error {
 }
 
 func (i *MetricInfo) validateAttributes() error {
+	tmp := pcommon.NewValueEmpty()
+
 	for _, attr := range i.Attributes {
 		if attr.Key == "" {
 			return errors.New("attribute key missing")
 		}
+
+		if err := tmp.FromRaw(attr.DefaultValue); err != nil {
+			return fmt.Errorf("invalid default value specified for attribute %s", attr.Key)
+		}
 	}
 	return nil
 }

connector/countconnector/config_test.go

@@ -422,6 +422,10 @@ func TestLoadConfig(t *testing.T) {
 								Key:          "request_success",
 								DefaultValue: float64(0.85),
 							},
+							{
+								Key:          "cache_hit",
+								DefaultValue: bool(true),
+							},
 						},
 					},
 				},

connector/countconnector/counter.go

@@ -45,22 +45,9 @@ func (c *counter[K]) update(ctx context.Context, attrs, scopeAttrs, resourceAttr
 				Name: attr.Key,
 				Value: func() *pcommon.Value {
 					if attr.DefaultValue != nil {
-						switch v := attr.DefaultValue.(type) {
-						case string:
-							if v != "" {
-								strV := pcommon.NewValueStr(v)
-								return &strV
-							}
-						case int:
-							if v != 0 {
-								intV := pcommon.NewValueInt(int64(v))
-								return &intV
-							}
-						case float64:
-							if v != 0 {
-								floatV := pcommon.NewValueDouble(v)
-								return &floatV
-							}
+						val := pcommon.NewValueEmpty()
+						if err := val.FromRaw(attr.DefaultValue); err == nil {
+							return &val
 						}
 					}
 
@@ -69,14 +56,8 @@ func (c *counter[K]) update(ctx context.Context, attrs, scopeAttrs, resourceAttr
 			}
 			value, ok := utilattri.GetDimensionValue(dimension, attrs, scopeAttrs, resourceAttrs)
 			if ok {
-				switch value.Type() {
-				case pcommon.ValueTypeInt:
-					countAttrs.PutInt(attr.Key, value.Int())
-				case pcommon.ValueTypeDouble:
-					countAttrs.PutDouble(attr.Key, value.Double())
-				default:
-					countAttrs.PutStr(attr.Key, value.Str())
-				}
+				countValue, _ := countAttrs.GetOrPutEmpty(attr.Key)
+				value.CopyTo(countValue)
 			}
 		}
 

connector/countconnector/counter_test.go

@@ -13,7 +13,7 @@ import (
 	"github.com/open-telemetry/opentelemetry-collector-contrib/pkg/pdatautil"
 )
 
-func Test_update_attributes(t *testing.T) {
+func Test_update_attribute_inheritance(t *testing.T) {
 	spanMetricDefs := make(map[string]metricDef[ottlspan.TransformContext])
 	spanMetricDefs[defaultMetricNameSpans] = metricDef[ottlspan.TransformContext]{
 		desc: defaultMetricDescSpans,
@@ -141,3 +141,96 @@ func Test_update_attributes(t *testing.T) {
 		})
 	}
 }
+
+func Test_update_attributes_types(t *testing.T) {
+	tests := []struct {
+		name         string
+		config       []AttributeConfig
+		inputAttr    pcommon.Map
+		expectedAttr pcommon.Map
+	}{
+		{
+			name: "attributes from DefaultValue",
+			config: []AttributeConfig{
+				{
+					Key:          "string",
+					DefaultValue: "default-string",
+				},
+				{
+					Key:          "int",
+					DefaultValue: 123,
+				},
+				{
+					Key:          "double",
+					DefaultValue: 321.0,
+				},
+				{
+					Key:          "bool",
+					DefaultValue: true,
+				},
+			},
+			inputAttr: pcommon.NewMap(),
+			expectedAttr: func() pcommon.Map {
+				res := pcommon.NewMap()
+				res.PutStr("string", "default-string")
+				res.PutInt("int", 123)
+				res.PutDouble("double", 321.0)
+				res.PutBool("bool", true)
+				return res
+			}(),
+		},
+		{
+			name: "attributes from resource",
+			config: []AttributeConfig{
+				{
+					Key: "string",
+				},
+				{
+					Key: "int",
+				},
+				{
+					Key: "double",
+				},
+				{
+					Key: "bool",
+				},
+			},
+			inputAttr: func() pcommon.Map {
+				res := pcommon.NewMap()
+				res.PutStr("string", "default-string")
+				res.PutInt("int", 123)
+				res.PutDouble("double", 321.0)
+				res.PutBool("bool", true)
+				return res
+			}(),
+			expectedAttr: func() pcommon.Map {
+				res := pcommon.NewMap()
+				res.PutStr("string", "default-string")
+				res.PutInt("int", 123)
+				res.PutDouble("double", 321.0)
+				res.PutBool("bool", true)
+				return res
+			}(),
+		},
+	}
+
+	for _, tt := range tests {
+		spanMetricDefs := make(map[string]metricDef[ottlspan.TransformContext])
+		spanMetricDefs[defaultMetricNameSpans] = metricDef[ottlspan.TransformContext]{
+			desc:  defaultMetricDescSpans,
+			attrs: tt.config,
+		}
+
+		t.Run(tt.name, func(t *testing.T) {
+			spansCounter := newCounter(spanMetricDefs)
+			err := spansCounter.update(t.Context(), pcommon.NewMap(), pcommon.NewMap(), tt.inputAttr, ottlspan.TransformContext{})
+			require.NoError(t, err)
+			require.NotNil(t, spansCounter)
+			m := spansCounter.counts[defaultMetricNameSpans]
+			expectKey := pdatautil.MapHash(tt.expectedAttr)
+			attrCount, ok := m[expectKey]
+			require.True(t, ok)
+			require.NotNil(t, attrCount)
+		})
+	}
+}

connector/countconnector/testdata/config.yaml

@@ -211,3 +211,5 @@
             default_value: 200
           - key: request_success
             default_value: 0.85
+          - key: cache_hit
+            default_value: true