[receiver/k8sobjects] revert standby mode behavior on leader election loss #44512
+50
−295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loss Signed-off-by: Paulo Dias <[email protected]>
paulojmdias
requested review from
a team,
ChrsMark,
TylerHelmuth and
dmitryax
as code owners
ChrsMark
reviewed
Dec 1, 2025
| }, | ||
| ) | ||
| kr.setting.Logger.Info("no longer leader, stopping") | ||
| err = kr.Shutdown(context.Background()) |
Member
There was a problem hiding this comment.
Mind adding a comment here to note that start callback is still registered to the extension and hence the instance is still capable to get started on lease acquisition?
(to clarify potential confusion as in #43084 (comment))
Member
Author
There was a problem hiding this comment.
I added comments to the following commit. PTAL
Signed-off-by: Paulo Dias <[email protected]>
…try-collector-contrib into feat/revert_43054 Signed-off-by: Paulo Dias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts the change introduced in #43054.
As discussed in the following thread, this is not so beneficial and should be reverted to keep the same behaviour in all the components which use the
k8sleaderelectorextension.