[encoding/googlecloudlogentry] Add support for GCP Cloud DNS Logs #44697
+1,090
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constanca-m
reviewed
Dec 2, 2025
Contributor
constanca-m
left a comment
constanca-m
left a comment
There was a problem hiding this comment.
Looks good mostly, a couple of comments
extension/encoding/googlecloudlogentryencodingextension/internal/dnslog/parser.go
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/internal/dnslog/parser.go
Outdated
Show resolved
Hide resolved
...googlecloudlogentryencodingextension/testdata/dnslog/dns_query_no_domain_error_expected.yaml
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
| | Original field | Log record attribute | | ||
| |---|---| | ||
| | `queryName` | `gcp.dns.query.name` | | ||
| | `queryType` | `gcp.dns.query.type` | |
Contributor
There was a problem hiding this comment.
Suggested change
| | `queryType` | `gcp.dns.query.type` | | |
| | `queryType` | `dns.question.type` | |
I assume this is the question type https://www.elastic.co/docs/reference/ecs/ecs-dns#field-dns-question-type
Contributor
Author
There was a problem hiding this comment.
Do you think it should be added to semconv?
Contributor
There was a problem hiding this comment.
Yes I do. I have already logged an issue for it open-telemetry/semantic-conventions#2432
Contributor
Author
There was a problem hiding this comment.
Leave this PR as draft awaiting for issue resolution.
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
constanca-m
reviewed
Dec 3, 2025
constanca-m
reviewed
Dec 3, 2025
extension/encoding/googlecloudlogentryencodingextension/internal/dnslog/parser.go
Outdated
Show resolved
Hide resolved
alexcams
force-pushed
the
add-cgp-ldns-logs
branch
2 times, most recently
from
492951d to
defafc9
Compare
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
extension/encoding/googlecloudlogentryencodingextension/README.md
Outdated
Show resolved
Hide resolved
alexcams
force-pushed
the
add-cgp-ldns-logs
branch
from
defafc9 to
4be3dd2
Compare
alexcams
force-pushed
the
add-cgp-ldns-logs
branch
from
4be3dd2 to
5a32afb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for parsing GCP DNS logs.
With this changes, the user will be able to see cloud dns logs reported information in log attributes instead of pasted as a raw json string into the log body, that could cause the user to overlook important info.
Link to tracking issue
Solves #44561
Testing
Added unit and functional tests.
Documentation
Updated README.md