Skip to content

Conversation

@odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Dec 3, 2025

Description

Link to tracking issue

Fixes #44693

@odubajDT odubajDT marked this pull request as ready for review December 3, 2025 12:32
@github-actions github-actions bot added the processor/k8sattributes k8s Attributes processor label Dec 3, 2025
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Signed-off-by: odubajDT <[email protected]>
Copy link
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should not move this to beta until we complete open-telemetry/semantic-conventions#3120?

I just realise that the amount of breaking changes between current SemConv and the k8sattributesprocessor component is fortunately not really big.

Based on the analysis of open-telemetry/semantic-conventions#3120 it's only the labels and the container.image.tag. #44700 also proved that.

In this, how about we deprecate this specific feature gate that's only about the labels and go directly with the generic k8sattributes.semconv.k8s.enableStable and k8sattributes.semconv.k8s.disableLegacy including the container.image.tag rename to container.image.tags?

(We should get a final confirmation from #43869 for the feature gate approach)

The feature gate pair should remain alpha until we complete #44700.

@odubajDT
Copy link
Contributor Author

odubajDT commented Dec 5, 2025

I guess we should not move this to beta until we complete open-telemetry/semantic-conventions#3120?

I just realise that the amount of breaking changes between current SemConv and the k8sattributesprocessor component is fortunately not really big.

Based on the analysis of open-telemetry/semantic-conventions#3120 it's only the labels and the container.image.tag. #44700 also proved that.

In this, how about we deprecate this specific feature gate that's only about the labels and go directly with the generic k8sattributes.semconv.k8s.enableStable and k8sattributes.semconv.k8s.disableLegacy including the container.image.tag rename to container.image.tags?

(We should get a final confirmation from #43869 for the feature gate approach)

The feature gate pair should remain alpha until we complete #44700.

Good point, I guess deprecating the feature gate is a special case. Do we have an approximate date when the generic k8sattributes.semconv.k8s.enableStable and k8sattributes.semconv.k8s.disableLegacy feature gates might be realistic to be accepted and used in the component?

My thinking is: If it takes long and we have already a feature gate in beta (this one), there is a chance, that until the generic feature gates become a realistic option, we might have this one already in stable and therefore reduce the amount of changes handled by the generic feature gates, since the labels/annotations at that time will met the SemConv. Just thinking out loud to keep things moving, but I am fine with both approaches.

Let me know what you think.

@ChrsMark
Copy link
Member

ChrsMark commented Dec 5, 2025

Good point, I guess deprecating the feature gate is a special case. Do we have an approximate date when the generic k8sattributes.semconv.k8s.enableStable and k8sattributes.semconv.k8s.disableLegacy feature gates might be realistic to be accepted and used in the component?

Based on recent discussions took place this week in both the Collector SIG and the System SemConv SIG meetings, I can say there is agreement on having feature gate pairs per component. @mx-psi will be writing something sth down about this soon. So I think we can wait a bit and go with this approach. In any case I would be hesitant to promote the current feature gate to beta (enabled by default) until we have open-telemetry/semantic-conventions#3120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

processor/k8sattributes k8s Attributes processor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[k8sattributes] Mature k8sattr.labelsAnnotationsSingular.allow feature gate

3 participants