Skip to content

Conversation

@florianl
Copy link
Contributor

@florianl florianl commented Dec 1, 2025

Description

Similar to (Logs) LogRecordCount() int, (Metrics) MetricCount() int and (Traces) SpanCount() int add ProfileCount().

Link to tracking issue

Fixes #

Testing

Documentation

@florianl florianl requested review from a team, dmathieu and mx-psi as code owners December 1, 2025 16:40
Similar to `(Logs) LogRecordCount() int`, `(Metrics) MetricCount() int` and `(Traces) SpanCount() int` add `ProfileCount()`.

Signed-off-by: Florian Lehner <[email protected]>
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 1, 2025

CodSpeed Performance Report

Merging #14239 will degrade performances by 37.24%

Comparing florianl:profiles-count (3ac14bc) with main (152042e)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 1 regression
✅ 72 untouched

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
zstdNoConcurrency 36.5 µs 58.1 µs -37.24%

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.15%. Comparing base (152042e) to head (3ac14bc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14239      +/-   ##
==========================================
- Coverage   92.18%   92.15%   -0.03%     
==========================================
  Files         668      668              
  Lines       41463    41472       +9     
==========================================
- Hits        38223    38220       -3     
- Misses       2209     2217       +8     
- Partials     1031     1035       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mx-psi mx-psi added this pull request to the merge queue Dec 2, 2025
Merged via the queue into open-telemetry:main with commit e5a962c Dec 2, 2025
61 of 62 checks passed
florianl added a commit to florianl/opentelemetry-collector that referenced this pull request Dec 3, 2025
In open-telemetry#14239 (Profiles)ProfileCount() was introduced. Provide this function also in consumertests.

Signed-off-by: Florian Lehner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants