-
Notifications
You must be signed in to change notification settings - Fork 706
refactor(otelhttp): change Version() func to const Version string #8142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
|
Apologies, I've updated the changelog.md. |
1f64ab7 to
0a266f5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8142 +/- ##
=======================================
- Coverage 81.8% 81.8% -0.1%
=======================================
Files 194 193 -1
Lines 13362 13360 -2
=======================================
- Hits 10936 10934 -2
Misses 2029 2029
Partials 397 397
🚀 New features to boost your workflow:
|
Co-authored-by: Flc゛ <[email protected]>
Co-authored-by: Damien Mathieu <[email protected]>
|
|
||
| ### Changed | ||
|
|
||
| - Change `Version()` function in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` to a `const Version` string. (#8142) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@open-telemetry/go-approvers I think we could make it more visible this is a breaking change. But at the same time, doing something too prominent for the version string probably too much. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to only mark content or tags related to significant changes here.
Fixes #8134
Changes the Version() definition in the otelhttp package from a function to a constant string for simplicity and consistency.