Skip to content

Conversation

@dogedede
Copy link

@dogedede dogedede commented Nov 7, 2025

Fixes #8134
Changes the Version() definition in the otelhttp package from a function to a constant string for simplicity and consistency.

@dogedede dogedede requested review from a team and dmathieu as code owners November 7, 2025 12:37
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 7, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dogedede / name: Andy (448ae1e)

@dogedede
Copy link
Author

dogedede commented Nov 7, 2025

Apologies, I've updated the changelog.md.

@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.8%. Comparing base (7ff03d6) to head (37c0b45).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8142     +/-   ##
=======================================
- Coverage   81.8%   81.8%   -0.1%     
=======================================
  Files        194     193      -1     
  Lines      13362   13360      -2     
=======================================
- Hits       10936   10934      -2     
  Misses      2029    2029             
  Partials     397     397             
Files with missing lines Coverage Δ
instrumentation/net/http/otelhttp/common.go 100.0% <100.0%> (ø)
instrumentation/net/http/otelhttp/config.go 82.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dogedede dogedede requested a review from dmathieu November 10, 2025 04:07
Co-authored-by: Flc゛ <[email protected]>
Co-authored-by: Damien Mathieu <[email protected]>

### Changed

- Change `Version()` function in `go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` to a `const Version` string. (#8142)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/go-approvers I think we could make it more visible this is a breaking change. But at the same time, doing something too prominent for the version string probably too much. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to only mark content or tags related to significant changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

otelhttp: func Version() string should just be const Version string

3 participants