Skip to content

Conversation

@paulojmdias
Copy link
Member

Relates to open-telemetry/opentelemetry-collector-contrib#42804

Changes

This PR introduces new cloud.provider and cloud.platform values for DigitalOcean (digitalocean) and DigitalOcean Compute (digitalocean_compute).
These additions align with the new DigitalOcean resource detection processor in the Collector and ensure consistent attribute naming across all resources.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

Signed-off-by: Paulo Dias <[email protected]>
@github-actions github-actions bot added enhancement New feature or request area:cloud labels Sep 21, 2025
songy23 pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Sep 24, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

This PR adds support for resource detection in DigitalOcean.

I'm proposing to be a code owner for this detector 🙌

Semantic Conventions PR:
open-telemetry/semantic-conventions#2790

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes #42803

<!--Describe what testing was performed and which tests were added.-->
#### Testing

Tests added and also tested on a DigitalOcean instance, as we can see
the output below.

```sh
2025-09-21T22:29:33.140Z	info	[email protected]/service.go:239	Starting otelcontribcol...	{"resource": {"service.instance.id": "e21da881-08da-47bf-b07a-ac501803050d", "service.name": "otelcontribcol", "service.version": "0.135.0-dev"}, "Version": "0.135.0-dev", "NumCPU": 1}
2025-09-21T22:29:33.140Z	info	extensions/extensions.go:41	Starting extensions...	{"resource": {"service.instance.id": "e21da881-08da-47bf-b07a-ac501803050d", "service.name": "otelcontribcol", "service.version": "0.135.0-dev"}}
2025-09-21T22:29:33.141Z	info	internal/resourcedetection.go:137	began detecting resource information	{"resource": {"service.instance.id": "e21da881-08da-47bf-b07a-ac501803050d", "service.name": "otelcontribcol", "service.version": "0.135.0-dev"}, "otelcol.component.id": "resourcedetection", "otelcol.component.kind": "processor", "otelcol.pipeline.id": "metrics", "otelcol.signal": "metrics"}
2025-09-21T22:29:33.178Z	info	internal/resourcedetection.go:188	detected resource information	{"resource": {"service.instance.id": "e21da881-08da-47bf-b07a-ac501803050d", "service.name": "otelcontribcol", "service.version": "0.135.0-dev"}, "otelcol.component.id": "resourcedetection", "otelcol.component.kind": "processor", "otelcol.pipeline.id": "metrics", "otelcol.signal": "metrics", "resource": {"cloud.provider":"digitalocean","cloud.region":"fra1","host.id":"520038265","host.name":"ubuntu-s-1vcpu-1gb-fra1-01"}}
2025-09-21T22:29:33.178Z	info	[email protected]/service.go:262	Everything is ready. Begin running and processing data.	{"resource": {"service.instance.id": "e21da881-08da-47bf-b07a-ac501803050d", "service.name": "otelcontribcol", "service.version": "0.135.0-dev"}}
2025-09-21T22:29:34.181Z	info	Metrics	{"resource": {"service.instance.id": "e21da881-08da-47bf-b07a-ac501803050d", "service.name": "otelcontribcol", "service.version": "0.135.0-dev"}, "otelcol.component.id": "debug", "otelcol.component.kind": "exporter", "otelcol.signal": "metrics", "resource metrics": 3, "metrics": 5, "data points": 17}
2025-09-21T22:29:34.182Z	info	ResourceMetrics #0
Resource SchemaURL: https://opentelemetry.io/schemas/1.9.0
Resource attributes:
     -> cloud.provider: Str(digitalocean)
     -> host.id: Str(520038265)
     -> host.name: Str(ubuntu-s-1vcpu-1gb-fra1-01)
     -> cloud.region: Str(fra1)
```

<!--Describe the documentation added.-->
#### Documentation

Updated the README.md with this new detector.

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Signed-off-by: Paulo Dias <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 7, 2025

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 7, 2025
@paulojmdias
Copy link
Member Author

/label -stale

@github-actions github-actions bot removed the Stale label Oct 8, 2025
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 23, 2025
@paulojmdias
Copy link
Member Author

/label -stale

@github-actions github-actions bot removed the Stale label Oct 24, 2025
@github-actions
Copy link

github-actions bot commented Nov 8, 2025

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 8, 2025
@paulojmdias
Copy link
Member Author

/label -stale

@github-actions github-actions bot removed the Stale label Nov 10, 2025
@github-actions
Copy link

This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:

  • cloud

Such changes may be rejected or put on hold until a new SIG/project is established.

Please refer to the Semantic Convention Areas
document to see the current active SIGs and also to learn how to kick start a new one.

@github-actions github-actions bot closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant