Skip to content

Conversation

@braddf
Copy link
Contributor

@braddf braddf commented Sep 10, 2024

Pull Request

Description

gsp/pvlive/all route docs said it should default regime to in-day if not specified; in reality, it defaults to None and gives us the expected behaviour of returning PV Live Updated where available, with Estimated values as fallback.

How Has This Been Tested?

  • Locally

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@braddf braddf added the documentation Improvements or additions to documentation label Sep 10, 2024
@braddf braddf self-assigned this Sep 10, 2024
Copy link
Collaborator

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also do this for the pvlive gsp route too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants