Skip to content

Conversation

@xiekeyang
Copy link
Contributor

@xiekeyang xiekeyang commented Mar 16, 2017

supplement of #103. Here we need fix 2:

  1. golint failed upper that go version 1.7
  2. add logrus package. Refer to Merging of subcommands #103 (comment)

Signed-off-by: xiekeyang [email protected]

@xiekeyang xiekeyang changed the title Add package of Sirupsen/logrus to vendor [WIP] Add package of Sirupsen/logrus to vendor Mar 16, 2017
@xiekeyang xiekeyang changed the title [WIP] Add package of Sirupsen/logrus to vendor Add package of Sirupsen/logrus to vendor Mar 16, 2017
xiekeyang added 2 commits March 16, 2017 16:56
@xiekeyang
Copy link
Contributor Author

xiekeyang commented Mar 16, 2017

I find github.com/vbatts/git-validation can help install non-existent packages to local, such as logrus, that pass travis CI. But I think we had better to keep as previous rules, to add needed package to glide.yaml, and commit it with code under vendor (for we should release buildable image tool package ), it is right?

@stevvooe
Copy link
Contributor

stevvooe commented Mar 16, 2017

LGTM

Approved with PullApprove

1 similar comment
@coolljt0725
Copy link
Member

coolljt0725 commented Mar 17, 2017

LGTM

Approved with PullApprove

@coolljt0725 coolljt0725 merged commit 1f48745 into opencontainers:master Mar 17, 2017
@xiekeyang xiekeyang deleted the logrus branch March 17, 2017 08:52
@xiekeyang xiekeyang mentioned this pull request Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants