Skip to content

Commit a107b20

Browse files
authored
Sync from kubeflow/model-registry 47db42a (#5249)
* Update @odh-dashboard/model-registry tracking to 876614fc368ab48bac69a17b7909df708b264d98 (no file changes) * Update @odh-dashboard/model-registry: Remove redundant 'Total hardware' column, fix duplicate React key errors (#1770) Upstream commit: 47db42afcaead66f0af7b0b6960d40135f6adfb4
1 parent 9ee8a7c commit a107b20

File tree

4 files changed

+3
-334
lines changed

4 files changed

+3
-334
lines changed

packages/model-registry/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"repo": "https://github.com/kubeflow/model-registry.git",
2323
"src": "clients/ui",
2424
"target": "upstream",
25-
"commit": "e67201d6509ae886c4daf5fa2312b36d52d4bb4a"
25+
"commit": "47db42afcaead66f0af7b0b6960d40135f6adfb4"
2626
},
2727
"module-federation": {
2828
"name": "modelRegistry",

packages/model-registry/upstream/frontend/src/app/pages/modelCatalog/components/HardwareConfigurationTable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ const HardwareConfigurationTable: React.FC<HardwareConfigurationTableProps> = ({
5656
emptyTableView={<DashboardEmptyTableView onClearFilters={handleClearFilters} />}
5757
rowRenderer={(artifact) => (
5858
<HardwareConfigurationTableRow
59-
key={`${artifact.customProperties.hardware_type?.string_value} ${artifact.customProperties.hardware_count?.int_value}`}
59+
key={artifact.customProperties.config_id?.string_value}
6060
performanceArtifact={artifact}
6161
/>
6262
)}

packages/model-registry/upstream/frontend/src/app/pages/modelCatalog/components/HardwareConfigurationTableColumns.ts

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
getHardwareConfiguration,
88
getTotalRps,
99
} from '~/app/pages/modelCatalog/utils/performanceMetricsUtils';
10-
import { getDoubleValue, getIntValue, getStringValue } from '~/app/utils';
10+
import { getDoubleValue, getStringValue } from '~/app/utils';
1111

1212
export type HardwareConfigColumnField = keyof PerformanceMetricsCustomProperties | 'total_rps';
1313

@@ -30,21 +30,7 @@ export const hardwareConfigColumns: HardwareConfigColumn[] = [
3030
isStickyColumn: true,
3131
stickyMinWidth: '162px',
3232
stickyLeftOffset: '0',
33-
modifier: 'wrap',
34-
},
35-
{
36-
field: 'hardware_count',
37-
label: 'Total Hardware',
38-
sortable: (
39-
a: CatalogPerformanceMetricsArtifact,
40-
b: CatalogPerformanceMetricsArtifact,
41-
): number =>
42-
getIntValue(a.customProperties, 'hardware_count') -
43-
getIntValue(b.customProperties, 'hardware_count'),
44-
isStickyColumn: true,
4533
hasRightBorder: true,
46-
stickyMinWidth: '130px',
47-
stickyLeftOffset: '162px',
4834
modifier: 'wrap',
4935
},
5036
{

packages/model-registry/upstream/frontend/src/app/pages/modelCatalog/components/HardwareConfigurationTableColumns.ts.backup

Lines changed: 0 additions & 317 deletions
This file was deleted.

0 commit comments

Comments
 (0)