Problem
In internal/controller/components/workbenches/workbenches.go at lines 143-145, the code incorrectly swallows client.Get errors by returning nil instead of propagating them:
if err := rr.Client.Get(ctx, client.ObjectKeyFromObject(&c), &c); err != nil && !k8serr.IsNotFound(err) {
return cs, nil // <- This hides real errors
}
This masks genuine failures and makes debugging difficult in production environments.
Suggested Fix
if err := rr.Client.Get(ctx, client.ObjectKeyFromObject(&c), &c); err != nil && !k8serr.IsNotFound(err) {
return cs, err // <- Properly bubble up the error
}
Context
Originally identified during code review of PR #2402: #2402 (comment)
/cc @jiridanek