Skip to content

Commit 53b5a8b

Browse files
authored
Merge pull request #37636 from openedx/feanil/fix_make_upgrade
build: Don't have both a pip and pip-tools requirements files.
2 parents 41acf0e + 834127e commit 53b5a8b

File tree

7 files changed

+10
-33
lines changed

7 files changed

+10
-33
lines changed

.github/workflows/ci-static-analysis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
run: sudo apt update && sudo apt install -y libxmlsec1-dev
2626

2727
- name: Install pip
28-
run: python -m pip install -r requirements/pip.txt
28+
run: make pre-requirements
2929

3030
- name: Get pip cache dir
3131
id: pip-cache-dir

.github/workflows/lint-imports.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
run: sudo apt update && sudo apt install -y libxmlsec1-dev
2626

2727
- name: Install pip
28-
run: python -m pip install -r requirements/pip.txt
28+
run: make pre-requirements
2929

3030
- name: Get pip cache dir
3131
id: pip-cache-dir
@@ -40,7 +40,7 @@ jobs:
4040
restore-keys: ${{ runner.os }}-pip-
4141

4242
- name: Install python dependencies
43-
run: pip install -r requirements/edx/development.txt
43+
run: make dev-requirements
4444

4545
# As long there are sub-projects[1] in edx-platform, we analyze each
4646
# project separately here, in order to make import-linting errors easier

Makefile

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ detect_changed_source_translations: ## check if translation files are up-to-date
6666
i18n_tool changed
6767

6868
pre-requirements: ## install Python requirements for running pip-tools
69-
pip install -r requirements/pip.txt
7069
pip install -r requirements/pip-tools.txt
7170

7271
local-requirements:
@@ -122,12 +121,10 @@ compile-requirements: pre-requirements $(COMMON_CONSTRAINTS_TXT) ## Re-compile *
122121
@# time someone tries to use the outputs.
123122
sed 's/Django<5.0//g' requirements/common_constraints.txt > requirements/common_constraints.tmp
124123
mv requirements/common_constraints.tmp requirements/common_constraints.txt
125-
sed 's/pip<24.3//g' requirements/common_constraints.txt > requirements/common_constraints.tmp
124+
sed 's/pip<25.3//g' requirements/common_constraints.txt > requirements/common_constraints.tmp
126125
mv requirements/common_constraints.tmp requirements/common_constraints.txt
127-
pip-compile -v --allow-unsafe ${COMPILE_OPTS} -o requirements/pip.txt requirements/pip.in
128-
pip install -r requirements/pip.txt
129126

130-
pip-compile -v ${COMPILE_OPTS} -o requirements/pip-tools.txt requirements/pip-tools.in
127+
pip-compile -v --allow-unsafe ${COMPILE_OPTS} -o requirements/pip-tools.txt requirements/pip-tools.in
131128
pip install -r requirements/pip-tools.txt
132129

133130
@ export REBUILD='--rebuild'; \

requirements/common_constraints.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,4 +28,4 @@ elasticsearch<7.14.0
2828
# See issue https://github.com/openedx/public-engineering/issues/440 for details regarding the ongoing fix.
2929
# The constraint can be removed once a release (pip-tools > 7.5.1) is available with support for pip 25.3
3030
# Issue to track this dependency and unpin later on: https://github.com/openedx/edx-lint/issues/503
31-
pip<25.3
31+

requirements/pip-tools.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,7 @@ wheel==0.45.1
2020
# via pip-tools
2121

2222
# The following packages are considered to be unsafe in a requirements file:
23-
# pip
24-
# setuptools
23+
pip==25.3
24+
# via pip-tools
25+
setuptools==80.9.0
26+
# via pip-tools

requirements/pip.in

Lines changed: 0 additions & 6 deletions
This file was deleted.

requirements/pip.txt

Lines changed: 0 additions & 16 deletions
This file was deleted.

0 commit comments

Comments
 (0)