Skip to content

Conversation

@Lunyachek
Copy link
Contributor

@Lunyachek Lunyachek commented Apr 15, 2025

Description

This PR is our proposal to update the Twitter icon to the new X logo in the user Profile and Account.
In this PR we updated the validation logic to align with the platform's rebranding from Twitter to X.

This PR is related to corresponding PRs in the frontend-app-profile and frontend-app-account repositories.

Снимок экрана 2025-04-15 в 14 04 57 Снимок экрана 2025-04-15 в 14 05 47

@Lunyachek Lunyachek requested a review from a team as a code owner April 15, 2025 10:58
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 15, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Apr 15, 2025

Thanks for the pull request, @Lunyachek!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 15, 2025
@Lunyachek Lunyachek marked this pull request as draft April 15, 2025 11:02
@Lunyachek Lunyachek changed the title draft: feat: Replace Twitter with X feat: Replace Twitter with X Apr 15, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 23, 2025
@Lunyachek Lunyachek force-pushed the lunyachek/feat/change-twitter-to-x branch from 5072c22 to b647dcc Compare April 30, 2025 16:06
@Lunyachek Lunyachek marked this pull request as ready for review April 30, 2025 16:06
@mphilbrick211 mphilbrick211 moved this from Waiting on Author to Ready for Review in Contributions May 12, 2025
@Lunyachek Lunyachek force-pushed the lunyachek/feat/change-twitter-to-x branch from b647dcc to 31c522a Compare July 2, 2025 15:56
@jsnwesson
Copy link
Member

Hi @Lunyachek ! I'm looking at this now, and I wondered if there is a potential impact for UserProfile objects that have a Twitter account in their SocialLink model.

Is there further work required by each organization to update the model so the 'twitter' substring in the platform and social_link properties is switched to 'x'? Is that something that be handled in this PR?

@arsentur
Copy link
Contributor

arsentur commented Jul 3, 2025

Hey @jsnwesson.
Thanks for pointing this out. I’ve checked it locally on the Teak release — old records are stored without any issues. The problem only occurs if you try to re-save the record without modifying the value (i.e., still using "Twitter" instead of "X"). In that case, it raises a This value is invalid. error. So in this case, users can change it by themselves on the change profile.

image

@arsentur arsentur force-pushed the lunyachek/feat/change-twitter-to-x branch 6 times, most recently from 4288bc0 to cbc8f87 Compare July 4, 2025 07:45
@jsnwesson
Copy link
Member

@Lunyachek thanks for checking! To confirm then, learners with their old Twitter URL will still have their URL appear in that field in Account and Profile MFE, which if they decide to edit they'll need to use the https://www.x.com/ prefix going forward?

@arsentur
Copy link
Contributor

arsentur commented Jul 9, 2025

@jsnwesson Yes, that's correct — the existing Twitter URLs will still appear in the Account and Profile MFE as they were. If learners choose to edit that field, they'll need to update it using the https://www.x.com/ prefix going forward.

Copy link
Member

@jsnwesson jsnwesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming, and I realized that this PR only handles updates to the user's social media links so thank you for your patience. 😅

@mphilbrick211 mphilbrick211 moved this from Ready for Review to Ready to Merge in Contributions Sep 12, 2025
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Sep 12, 2025
@Lunyachek Lunyachek force-pushed the lunyachek/feat/change-twitter-to-x branch from cbc8f87 to f3e8c7f Compare October 2, 2025 09:50
@Lunyachek Lunyachek requested a review from a team as a code owner October 2, 2025 09:50
@sarina
Copy link
Contributor

sarina commented Oct 14, 2025

It looks like this PR already has 3 approvals, but @Lunyachek it requires a rebase. After that are we waiting for more reviews?

@mphilbrick211 mphilbrick211 removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Nov 13, 2025
@feanil
Copy link
Contributor

feanil commented Nov 19, 2025

@Lunyachek can you rebase this PR so we can land it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready to Merge

Development

Successfully merging this pull request may close these issues.

9 participants