-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat: Replace Twitter with X #36524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Replace Twitter with X #36524
Conversation
|
Thanks for the pull request, @Lunyachek! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
5072c22 to
b647dcc
Compare
b647dcc to
31c522a
Compare
|
Hi @Lunyachek ! I'm looking at this now, and I wondered if there is a potential impact for Is there further work required by each organization to update the model so the 'twitter' substring in the |
|
Hey @jsnwesson. |
4288bc0 to
cbc8f87
Compare
|
@Lunyachek thanks for checking! To confirm then, learners with their old Twitter URL will still have their URL appear in that field in Account and Profile MFE, which if they decide to edit they'll need to use the |
|
@jsnwesson Yes, that's correct — the existing Twitter URLs will still appear in the Account and Profile MFE as they were. If learners choose to edit that field, they'll need to update it using the https://www.x.com/ prefix going forward. |
jsnwesson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for confirming, and I realized that this PR only handles updates to the user's social media links so thank you for your patience. 😅
cbc8f87 to
f3e8c7f
Compare
|
It looks like this PR already has 3 approvals, but @Lunyachek it requires a rebase. After that are we waiting for more reviews? |
|
@Lunyachek can you rebase this PR so we can land it? |

Description
This PR is our proposal to update the Twitter icon to the new X logo in the user Profile and Account.
In this PR we updated the validation logic to align with the platform's rebranding from Twitter to X.
This PR is related to corresponding PRs in the frontend-app-profile and frontend-app-account repositories.