Skip to content

Conversation

@ttqureshi
Copy link
Member

@ttqureshi ttqureshi commented Nov 21, 2025

It is the test PR for: openedx/xblocks-contrib#111

In this PR we are rolling out the Extracted HTML XBlock by toggling the USE_EXTRACTED_HTML_BLOCK flag to True.
The following Acceptance Criteria should be tested on the Sandbox before merging this PR.

Acceptance Criteria

  • HTML block can be created in a V2 library, edited, published
  • HTML block from a library can be used in a course, and its text can be overridden
  • HTML block can be created in a course, edited, publislhed
  • HTML block can be viewed in LMS
  • HTML block imports from OLX when it's a pointer tag
  • HTML block imports from OLX when it's inline
  • HTML block exports to OLX as a pointer tag
  • The exported course should be same as the course when BuiltIn HTML block is enabled
  • All the HTML sublclassess still work (StaticTab, About, CourseInfo)

TODO:

  • Remove the fail-fast: false setting in unit-tests.yml before merging.

@openedx-webhooks
Copy link

openedx-webhooks commented Nov 21, 2025

Thanks for the pull request, @ttqureshi!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 21, 2025
@ttqureshi ttqureshi self-assigned this Nov 21, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Nov 21, 2025
@ttqureshi ttqureshi added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Nov 21, 2025
@ttqureshi ttqureshi changed the title chore: change pip installation to git branch installation Test the XML import/export functionality of the extracted HTML XBlock Nov 21, 2025
@ttqureshi ttqureshi marked this pull request as draft November 21, 2025 12:12
@ttqureshi ttqureshi force-pushed the ttqureshi/enable-html branch from ae1996d to 462cfcd Compare November 21, 2025 12:13
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@ttqureshi ttqureshi force-pushed the ttqureshi/enable-html branch from 52ffdc5 to ff1d7e9 Compare November 27, 2025 14:24
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@ttqureshi ttqureshi force-pushed the ttqureshi/enable-html branch from 5c14740 to fc55b6e Compare November 27, 2025 16:43
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@farhan farhan self-requested a review November 28, 2025 07:03
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@ttqureshi ttqureshi changed the title Test the XML import/export functionality of the extracted HTML XBlock Enable the Extracted HTML XBlock Dec 3, 2025
@ttqureshi ttqureshi marked this pull request as ready for review December 3, 2025 06:41
@ttqureshi ttqureshi force-pushed the ttqureshi/enable-html branch from d3eb550 to 33e314c Compare December 3, 2025 07:18
@ttqureshi ttqureshi requested a review from irtazaakram December 3, 2025 08:00
Copy link
Member

@irtazaakram irtazaakram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@ttqureshi
Copy link
Member Author

ttqureshi commented Dec 3, 2025

@kdmccormick

@irtazaakram and I have done the final testing of the HTML XBlock and everything seems to be working fine as expected. It's now ready to be rolled out 🚀

cc: @farhan

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@kdmccormick
Copy link
Member

kdmccormick commented Dec 3, 2025

All the HTML sublclassess still work (StaticTab, About, CourseInfo)

did you check this one @ttqureshi ?

@kdmccormick
Copy link
Member

From slack

Right now, these subclasses are extending form the BuiltIn HTML XBlock instead of the extracted one. I believe we can make a seperate PR for these subclasses in the edx-platform to test their functionality.

ah, OK, yes let's make a follow up PR for that soon.

@kdmccormick kdmccormick merged commit 1fed4be into openedx:master Dec 3, 2025
49 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Dec 3, 2025
@kdmccormick
Copy link
Member

ticket for followup with subclasses:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants