-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Enable the Extracted HTML XBlock #37669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @ttqureshi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
ae1996d to
462cfcd
Compare
|
Sandbox deployment failed 💥 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
52ffdc5 to
ff1d7e9
Compare
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
5c14740 to
fc55b6e
Compare
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
d3eb550 to
33e314c
Compare
irtazaakram
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
|
@irtazaakram and I have done the final testing of the HTML XBlock and everything seems to be working fine as expected. It's now ready to be rolled out 🚀 cc: @farhan |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
did you check this one @ttqureshi ? |
|
From slack
|
|
ticket for followup with subclasses: |
It is the test PR for: openedx/xblocks-contrib#111
In this PR we are rolling out the Extracted HTML XBlock by toggling the
USE_EXTRACTED_HTML_BLOCKflag toTrue.The following Acceptance Criteria should be tested on the Sandbox before merging this PR.
Acceptance Criteria
TODO:
fail-fast: falsesetting inunit-tests.ymlbefore merging.