Skip to content

Commit c25078b

Browse files
authored
Merge pull request #495 from saraburns1/json_utf_fix
fix: keep unicode characters in problem response list
2 parents f1dfcf6 + bfce256 commit c25078b

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

CHANGELOG.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ Change Log
1111

1212
.. There should always be an "Unreleased" section for changes pending release.
1313
14+
[9.3.3]
15+
16+
* Fixes bad decoding of unicode characrters during json dumps
17+
1418
[9.3.2]
1519

1620
* Fixes issues with gzip files and duplicated events

event_routing_backends/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
Various backends for receiving edX LMS events..
33
"""
44

5-
__version__ = '9.3.2'
5+
__version__ = '9.3.3'

event_routing_backends/processors/tests/fixtures/current/problem_check(server).list_answers.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -147,10 +147,10 @@
147147
"a0effb954cca4759994f1ac9e9434bf4_5_1": {
148148
"question": "",
149149
"answer": [
150-
"Un emprunt \u00e0 l'anglais ou anglicisme",
150+
"Un emprunt à l'anglais ou anglicisme",
151151
"Un type de demande",
152-
"Quelque chose de rapide, d'instantan\u00e9",
153-
"Une question structur\u00e9e et pr\u00e9cise",
152+
"Quelque chose de rapide, d'instantané",
153+
"Une question structuré et précise",
154154
"Un type de poisson",
155155
"I\"M SWP' \"SDF\""
156156
],

event_routing_backends/processors/xapi/event_transformers/problem_interaction_events.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -509,4 +509,4 @@ def response(self, value):
509509
if not isinstance(value, list):
510510
raise ValueError(f"JSONEncodedResult only accepts lists, {type(value)} given.")
511511

512-
self._response = json.dumps(value)
512+
self._response = json.dumps(value, ensure_ascii=False)

event_routing_backends/processors/xapi/tests/fixtures/expected/problem_check(server).list_answers.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@
131131
"id": "707a78e0-c017-5a78-9581-df5bcca031c9",
132132
"result": {
133133
"success": false,
134-
"response": "[\"Un emprunt \\u00e0 l'anglais ou anglicisme\", \"Un type de demande\", \"Quelque chose de rapide, d'instantan\\u00e9\", \"Une question structur\\u00e9e et pr\\u00e9cise\", \"Un type de poisson\", \"I\\\"M SWP' \\\"SDF\\\"\"]"
134+
"response": "[\"Un emprunt à l'anglais ou anglicisme\", \"Un type de demande\", \"Quelque chose de rapide, d'instantané\", \"Une question structuré et précise\", \"Un type de poisson\", \"I\\\"M SWP' \\\"SDF\\\"\"]"
135135
},
136136
"version": "1.0.3",
137137
"actor": {

0 commit comments

Comments
 (0)