-
Notifications
You must be signed in to change notification settings - Fork 39
Open
Description
Plan
- fix: silence legacy-js-api Sass depr warning #639
- Upgrade
sass-loader
Context (originally posted in #wg-frontend on slack)
Anyone have thoughts on the
sass-loaderlegacy JS API deprecation? A warning pops up when running MFEs locally. There are some details about it here https://sass-lang.com/documentation/breaking-changes/legacy-js-api/#bundlersA warning pops up when running MFEs locally. There are some details about it here https://sass-lang.com/documentation/breaking-changes/legacy-js-api/#bundlers
It seems to boil down to:
- We're using
"sass-loader": "13.3.3"(https://github.com/openedx/frontend-build/blob/dac48980a9a2d4544d448c4096256a8cbca0a280/package.json#L89)(- The "
modern" API is not the default untilsass-loaderv16.0.0(https://github.com/webpack-contrib/sass-loader/releases/tag/v16.0.0)I see 2 options:
- Silence the deprecation for now (https://sass-lang.com/documentation/breaking-changes/legacy-js-api/#silencing-warnings)
OR
- Upgrade
sass-loader(and maybe usesass-embedded? https://webpack.js.org/loaders/sass-loader/#api notes "Usingmodern-compilerandsass-embeddedtogether significantly improve performance and decrease built time. We strongly recommend their use. We will enable them by default in a future major release."I'm leaning towards silencing the deprecation warning until we cut Teak and upgrading for Ulmo, but I'm very open to hearing other thoughts on the matter!
Metadata
Metadata
Assignees
Labels
No labels