test: fix silent failures by moving some scripts to makefile (#3833)

Author: brian-smith-tcril

.github/workflows/ci.yml

@@ -26,7 +26,7 @@ jobs:
     - name: Check Types
       run: npm run type-check
     - name: Lint
-      run: npm run lint
+      run: make lint
     - name: Test
       run: npm run test
     - name: Verify icon changes
@@ -42,7 +42,7 @@ jobs:
     - name: Build
       run: npm run build
     - name: Build Docs
-      run: npm run build-docs
+      run: make build-docs
     - name: Coverage
       uses: codecov/codecov-action@v4
       with:

Makefile

@@ -32,6 +32,26 @@ test.npm.%: validate-no-uncommitted-package-lock-changes
 requirements:  ## install ci requirements
 	npm ci
 
+# npm swallows errors
+# see https://github.com/openedx/paragon/issues/3329
+# 
+# Instead of having this directly in the build-docs script
+# in the top-level package.json, put it here so we can have
+# a single source of truth and get proper error codes in CI
+.PHONY: build-docs
+build-docs:
+	npm run build --workspace=www
+
+# npm swallows errors
+# see https://github.com/openedx/paragon/issues/3329
+# 
+# Instead of having this directly in the lint script
+# in the top-level package.json, put it here so we can have
+# a single source of truth and get proper error codes in CI
+.PHONY: lint
+lint:
+	npm run stylelint && npm run eslint && npm run lint --workspaces --if-present
+
 i18n.extract:
 	# Pulling display strings from .jsx files into .json files...
 	npm run-script i18n_extract

package.json

@@ -27,11 +27,12 @@
   "sideEffects": false,
   "scripts": {
     "build": "make build",
-    "build-docs": "npm run build --workspace=www",
+    "build-docs": "make build-docs",
     "commit": "commit",
     "debug-test": "node --inspect-brk node_modules/.bin/jest --runInBand --coverage",
     "stylelint": "stylelint \"src/**/*.scss\" \"scss/**/*.scss\" \"www/src/**/*.scss\" --config .stylelintrc.json",
-    "lint": "npm run stylelint && eslint --ext .js --ext .jsx --ext .ts --ext .tsx --ext .json . && npm run lint --workspaces --if-present",
+    "eslint": "eslint --ext .js --ext .jsx --ext .ts --ext .tsx --ext .json .",
+    "lint": "make lint",
     "lint:fix": "npm run stylelint && eslint --fix --ext .js --ext .jsx --ext .ts --ext .tsx --ext .json . && npm run lint --workspaces --if-present",
     "prepublishOnly": "npm run build",
     "semantic-release": "semantic-release",