-
Notifications
You must be signed in to change notification settings - Fork 3
move pointer tag common utility functions to xml_utils and add pointer tag support in HTML XBlock
#102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @ttqureshi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
de1544d to
0a36a68
Compare
xml_utils.pyxml_utils
1babd1b to
7e28de9
Compare
xml_utilsxml_utils and pointer tag support in HTML XBlock
xml_utils and pointer tag support in HTML XBlockxml_utils and add pointer tag support in HTML XBlock
7e28de9 to
05e3053
Compare
05e3053 to
c57e3b0
Compare
farhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, just minor doc improvements
9951942 to
610d236
Compare
farhan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work ⭐
|
@ttqureshi Please mention, how did you do its manual testing |
|
TESTING NOTES: After that, I imported the course (which included the pointer tag definitions of the HTML block), and all HTML blocks were initialized correctly, as expected. |
|
@kdmccormick this PR is up for your reivew. Please take a look. |
kdmccormick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add type annotations for every argument and return value?
Otherwise, looks good!
|
PR is up for the final pass. |
xml_utilsand add support for pointer tag utilities in the HTML XBlock. public-engineering#435The utility functions in xml_utils are derived from the XmlMixin class in the edx-platform. We are only retaining the functionality related to pointer tag parsing, ensuring that Extracted XBlocks can be exported and imported in the pointer tag format without any issue.
Here are the detailed references:
name_to_pathnameis_pointer_tagserialize_fielddeserialize_fieldown_metadataapply_pointer_attributesformat_filepathfile_to_xmlload_fileload_definition_xmlEdxJSONEncoder