-
Notifications
You must be signed in to change notification settings - Fork 3
Add pointer tag OLX format support in the WordCloud and LTI XBlocks #107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ttqureshi
commented
Nov 7, 2025
- resolves: Add support for pointer tag support in the WordCloud and LTI XBlocks public-engineering#441
|
Thanks for the pull request, @ttqureshi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
6772354 to
c43cd0f
Compare
344f843 to
698a26d
Compare
698a26d to
3e10a9d
Compare
c05669f to
30f2d40
Compare
|
This PR is up for review cc: @openedx/axim-aximprovements |
kdmccormick
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that I'd originally asked that XmlMixin not be brought in from edx-platform. When I asked that, I didn't realize how much code would need to be brought into each individual block in order to support pointer tags. This would be a lot of duplicated code.
@ttqureshi , could you refactor this so that the shared methods are in a mixin, just like they were in edx-platform? Call it LegacyXmlMixin, and add a docstring clarifying that it's a temporary solution and that we don't want new blocks to use the mixin.
|
@kdmccormick |