Skip to content

Conversation

@ttqureshi
Copy link
Member

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 7, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 7, 2025

Thanks for the pull request, @ttqureshi!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Nov 7, 2025
@ttqureshi ttqureshi marked this pull request as draft November 7, 2025 15:05
@ttqureshi ttqureshi self-assigned this Nov 7, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Nov 13, 2025
@ttqureshi ttqureshi force-pushed the ttqureshi/lti-wordcloud-pointertag branch 2 times, most recently from 6772354 to c43cd0f Compare November 14, 2025 06:50
@ttqureshi ttqureshi force-pushed the ttqureshi/lti-wordcloud-pointertag branch 2 times, most recently from 344f843 to 698a26d Compare November 14, 2025 07:13
@ttqureshi ttqureshi force-pushed the ttqureshi/lti-wordcloud-pointertag branch from 698a26d to 3e10a9d Compare November 14, 2025 10:28
@ttqureshi ttqureshi force-pushed the ttqureshi/lti-wordcloud-pointertag branch from c05669f to 30f2d40 Compare November 17, 2025 11:18
@ttqureshi ttqureshi marked this pull request as ready for review November 17, 2025 16:01
@ttqureshi ttqureshi requested a review from farhan November 17, 2025 16:01
@ttqureshi
Copy link
Member Author

This PR is up for review

cc: @openedx/axim-aximprovements

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that I'd originally asked that XmlMixin not be brought in from edx-platform. When I asked that, I didn't realize how much code would need to be brought into each individual block in order to support pointer tags. This would be a lot of duplicated code.

@ttqureshi , could you refactor this so that the shared methods are in a mixin, just like they were in edx-platform? Call it LegacyXmlMixin, and add a docstring clarifying that it's a temporary solution and that we don't want new blocks to use the mixin.

@ttqureshi
Copy link
Member Author

@kdmccormick
Alright! Let me go ahead with this approach. It sounds more reasonable to have LegacyXmlMixin as a shared utility. I'm going to add this mixin in the xml_utils file and all our extracted XBlocks will extend from this. And yeah, I'll mention in the docstring that it's a temporary solution, we will remove it in the future improvements.

@ttqureshi ttqureshi marked this pull request as draft November 18, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

Add support for pointer tag support in the WordCloud and LTI XBlocks

4 participants