Skip to content

Conversation

@salman2013
Copy link
Contributor

@salman2013 salman2013 commented Sep 9, 2025

Description: Run Js tests with karma.

Note: This is a draft PR, right now tests are running on the following specs. For further specs it is under progress.

  1. async_process_spec.js
  2. completion_spec.js
  3. general_spec.js
  4. initialize_spec.js
  5. iterator_spec.js
  6. resizer_spec.js
  7. sjson_spec.js
  8. social_share_spec.js
  9. video_context_menu_spec.js
  10. video_focus_grabber_spec.js
  11. video_full_screen_spec.js
  12. video_play_pause_control_spec.js
  13. video_play_placeholder_spec.js
  14. video_play_skip_control_spec.js
  15. video_quality_control_spec.js
  16. video_save_state_plugin_spec.js
  17. video_skip_control_spec.js
  18. video_storage_spec.js
  19. video_transcript_feedback_spec.js
  20. video_volume_control_spec.js
  21. video_autoadvance_spec.js

How to test PR locally:

Dependencies Requirements:

  • Install Node.js + npm
  • Install dependencies (npm install)
  • As the karma run tests on browser so make sure browsers are installed on your machine, right now in this draft PR tests are running on Firefox so it would need firefox browser but in case you want to test on chrome, update the browsers field in 'karma.common.conf' file.

like in karma.common.conf.js

browsers: ['Firefox'] --> browsers: ['Chrome']

How to run:

  • Run npm run build-dev command to build webpack config in development mode.
  • Run npm run karma-debug command to run the karma tests.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 9, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @salman2013!

This repository is currently maintained by @openedx/axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Blocked in Contributions Sep 10, 2025
@mphilbrick211 mphilbrick211 moved this from Blocked to Waiting on Author in Contributions Sep 10, 2025
@farhan farhan force-pushed the extract-video-xblock branch 4 times, most recently from 37540df to 69a09f6 Compare September 23, 2025 07:50
@farhan farhan force-pushed the extract-video-xblock branch 4 times, most recently from 9b57a79 to 0c0d3e5 Compare September 23, 2025 15:51
@salman2013
Copy link
Contributor Author

Creating new PR #92

@salman2013 salman2013 closed this Oct 14, 2025
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants