re-declare methods as external

Author: andresilva

contracts/OperationsProxy.sol

@@ -85,23 +85,23 @@ contract OperationsProxy {
 	}
 
 	function setOwner(address _owner)
-		public
+		external
 		onlyOwner
 	{
 		emit OwnerChanged(owner, _owner);
 		owner = _owner;
 	}
 
 	function setDelegate(address _delegate, uint8 _track)
-		public
+		external
 		onlyOwner
 	{
 		emit DelegateChanged(delegate[_track], _delegate, _track);
 		delegate[_track] = _delegate;
 	}
 
 	function setConfirmer(address _confirmer, uint8 _track)
-		public
+		external
 		onlyOwner
 	{
 		emit ConfirmerChanged(confirmer[_track], _confirmer, _track);
@@ -115,7 +115,7 @@ contract OperationsProxy {
 		uint24 _semver,
 		bool _critical
 	)
-		public
+		external
 		onlyDelegateOf(_track)
 	{
 		bool relayed;
@@ -129,7 +129,7 @@ contract OperationsProxy {
 	}
 
 	function addChecksum(bytes32 _release, bytes32 _platform, bytes32 _checksum)
-		public
+		external
 	{
 		uint8 track = trackOfPendingRelease[_release];
 		if (track == 0) {
@@ -142,7 +142,7 @@ contract OperationsProxy {
 	}
 
 	function confirm(uint8 _track, bytes32 _hash)
-		public
+		external
 		onlyConfirmerOf(_track)
 	{
 		bytes memory request = waiting[_track][_hash];
@@ -155,7 +155,7 @@ contract OperationsProxy {
 	}
 
 	function reject(uint8 _track, bytes32 _hash)
-		public
+		external
 		onlyConfirmerOf(_track)
 	{
 		delete waiting[_track][_hash];

contracts/SimpleOperations.sol

@@ -72,7 +72,7 @@ contract SimpleOperations is Operations {
 	// Functions for client owners
 
 	function setClientOwner(address _newOwner)
-		public
+		external
 		onlyClientOwner
 		notClientOwner(_newOwner)
 	{
@@ -95,7 +95,7 @@ contract SimpleOperations is Operations {
 		uint24 _semver,
 		bool _critical
 	)
-		public
+		external
 		onlyClientOwner
 	{
 		require(_track != 0 && _semver != 0);
@@ -123,7 +123,7 @@ contract SimpleOperations is Operations {
 	/// multiple times (with different parameters), therefore the `ChecksumAdded` event can be
 	/// emitted multiple times for the same checksum.
 	function addChecksum(bytes32 _release, bytes32 _platform, bytes32 _checksum)
-		public
+		external
 		onlyClientOwner
 	{
 		bytes32 newClient = clientOwner[msg.sender];
@@ -141,7 +141,7 @@ contract SimpleOperations is Operations {
 	// Admin functions
 
 	function setClient(bytes32 _client, address _owner)
-		public
+		external
 		onlyOwner
 		notClientOwner(_owner)
 	{
@@ -159,7 +159,7 @@ contract SimpleOperations is Operations {
 	// the data. If a removed client is then re-added (with `setClient`) all of the previous release
 	// and build information is available and returned by the getters.
 	function removeClient(bytes32 _client)
-		public
+		external
 		onlyOwner
 	{
 		address owner = client[_client].owner;
@@ -168,15 +168,15 @@ contract SimpleOperations is Operations {
 	}
 
 	function setLatestFork(uint32 _forkNumber)
-		public
+		external
 		onlyOwner
 	{
 		emit ForkRatified(_forkNumber);
 		latestFork = _forkNumber;
 	}
 
 	function setOwner(address _newOwner)
-		public
+		external
 		onlyOwner
 	{
 		emit OwnerChanged(grandOwner, _newOwner);
@@ -186,39 +186,16 @@ contract SimpleOperations is Operations {
 	// Getters
 
 	function isLatest(bytes32 _client, bytes32 _release)
-		public
+		external
 		view
 		returns (bool)
 	{
-		return clientExists(_client) && latestInTrack(_client, track(_client, _release)) == _release;
-	}
-
-	function track(bytes32 _client, bytes32 _release)
-		public
-		view
-		returns (uint8)
-	{
-		if (clientExists(_client)) {
-			return client[_client].release[_release].track;
-		} else {
-			return 0;
-		}
-	}
-
-	function latestInTrack(bytes32 _client, uint8 _track)
-		public
-		view
-		returns (bytes32)
-	{
-		if (clientExists(_client)) {
-			return client[_client].current[_track];
-		} else {
-			return 0;
-		}
+		return clientExists(_client) &&
+			latestInTrack(_client, track(_client, _release)) == _release;
 	}
 
 	function build(bytes32 _client, bytes32 _checksum)
-		public
+		external
 		view
 		returns (bytes32 o_release, bytes32 o_platform)
 	{
@@ -233,7 +210,7 @@ contract SimpleOperations is Operations {
 	}
 
 	function release(bytes32 _client, bytes32 _release)
-		public
+		external
 		view
 		returns (
 			uint32 o_forkBlock,
@@ -257,7 +234,7 @@ contract SimpleOperations is Operations {
 	}
 
 	function checksum(bytes32 _client, bytes32 _release, bytes32 _platform)
-		public
+		external
 		view
 		returns (bytes32)
 	{
@@ -269,21 +246,45 @@ contract SimpleOperations is Operations {
 	}
 
 	function latestFork()
-		public
+		external
 		view
 		returns (uint32)
 	{
 		return latestFork;
 	}
 
 	function clientOwner(address _owner)
-		public
+		external
 		view
 		returns (bytes32)
 	{
 		return clientOwner[_owner];
 	}
 
+	function track(bytes32 _client, bytes32 _release)
+		public
+		view
+		returns (uint8)
+	{
+		if (clientExists(_client)) {
+			return client[_client].release[_release].track;
+		} else {
+			return 0;
+		}
+	}
+
+	function latestInTrack(bytes32 _client, uint8 _track)
+		public
+		view
+		returns (bytes32)
+	{
+		if (clientExists(_client)) {
+			return client[_client].current[_track];
+		} else {
+			return 0;
+		}
+	}
+
 	// Internals
 
 	function clientExists(bytes32 _client)