Skip to content

Commit 7c659da

Browse files
committed
re-declare all methods as external
1 parent d16e64f commit 7c659da

File tree

1 file changed

+17
-16
lines changed

1 file changed

+17
-16
lines changed

contracts/SimpleOperations.sol

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ contract SimpleOperations is Operations {
7272
// Functions for client owners
7373

7474
function setClientOwner(address _newOwner)
75-
public
75+
external
7676
onlyClientOwner
7777
notClientOwner(_newOwner)
7878
{
@@ -95,7 +95,7 @@ contract SimpleOperations is Operations {
9595
uint24 _semver,
9696
bool _critical
9797
)
98-
public
98+
external
9999
onlyClientOwner
100100
{
101101
require(_track != 0 && _semver != 0);
@@ -123,7 +123,7 @@ contract SimpleOperations is Operations {
123123
/// multiple times (with different parameters), therefore the `ChecksumAdded` event can be
124124
/// emitted multiple times for the same checksum.
125125
function addChecksum(bytes32 _release, bytes32 _platform, bytes32 _checksum)
126-
public
126+
external
127127
onlyClientOwner
128128
{
129129
bytes32 newClient = clientOwner[msg.sender];
@@ -141,7 +141,7 @@ contract SimpleOperations is Operations {
141141
// Admin functions
142142

143143
function setClient(bytes32 _client, address _owner)
144-
public
144+
external
145145
onlyOwner
146146
notClientOwner(_owner)
147147
{
@@ -159,7 +159,7 @@ contract SimpleOperations is Operations {
159159
// the data. If a removed client is then re-added (with `setClient`) all of the previous release
160160
// and build information is available and returned by the getters.
161161
function removeClient(bytes32 _client)
162-
public
162+
external
163163
onlyOwner
164164
{
165165
address owner = client[_client].owner;
@@ -168,15 +168,15 @@ contract SimpleOperations is Operations {
168168
}
169169

170170
function setLatestFork(uint32 _forkNumber)
171-
public
171+
external
172172
onlyOwner
173173
{
174174
emit ForkRatified(_forkNumber);
175175
latestFork = _forkNumber;
176176
}
177177

178178
function setOwner(address _newOwner)
179-
public
179+
external
180180
onlyOwner
181181
{
182182
emit OwnerChanged(grandOwner, _newOwner);
@@ -186,15 +186,16 @@ contract SimpleOperations is Operations {
186186
// Getters
187187

188188
function isLatest(bytes32 _client, bytes32 _release)
189-
public
189+
external
190190
view
191191
returns (bool)
192192
{
193-
return clientExists(_client) && latestInTrack(_client, track(_client, _release)) == _release;
193+
return clientExists(_client) &&
194+
this.latestInTrack(_client, this.track(_client, _release)) == _release;
194195
}
195196

196197
function track(bytes32 _client, bytes32 _release)
197-
public
198+
external
198199
view
199200
returns (uint8)
200201
{
@@ -206,7 +207,7 @@ contract SimpleOperations is Operations {
206207
}
207208

208209
function latestInTrack(bytes32 _client, uint8 _track)
209-
public
210+
external
210211
view
211212
returns (bytes32)
212213
{
@@ -218,7 +219,7 @@ contract SimpleOperations is Operations {
218219
}
219220

220221
function build(bytes32 _client, bytes32 _checksum)
221-
public
222+
external
222223
view
223224
returns (bytes32 o_release, bytes32 o_platform)
224225
{
@@ -233,7 +234,7 @@ contract SimpleOperations is Operations {
233234
}
234235

235236
function release(bytes32 _client, bytes32 _release)
236-
public
237+
external
237238
view
238239
returns (
239240
uint32 o_forkBlock,
@@ -257,7 +258,7 @@ contract SimpleOperations is Operations {
257258
}
258259

259260
function checksum(bytes32 _client, bytes32 _release, bytes32 _platform)
260-
public
261+
external
261262
view
262263
returns (bytes32)
263264
{
@@ -269,15 +270,15 @@ contract SimpleOperations is Operations {
269270
}
270271

271272
function latestFork()
272-
public
273+
external
273274
view
274275
returns (uint32)
275276
{
276277
return latestFork;
277278
}
278279

279280
function clientOwner(address _owner)
280-
public
281+
external
281282
view
282283
returns (bytes32)
283284
{

0 commit comments

Comments
 (0)