Skip to content

Minor fixes #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andresilva wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Minor fixes #10

andresilva wants to merge 7 commits into from

Conversation

@andresilva
Copy link
Collaborator

@andresilva andresilva commented Jun 1, 2018

Minor fixes to match code style and development guidelines.

@andresilva andresilva requested a review from tomusdrw as a code owner June 1, 2018 12:08
@andresilva andresilva requested a review from sorpaas June 1, 2018 12:08
@coveralls
Copy link

coveralls commented Jun 1, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 147

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 131: 0.0%
Covered Lines: 122
Relevant Lines: 122
💛 - Coveralls

sorpaas
sorpaas approved these changes Jun 1, 2018
View reviewed changes
Copy link

@sorpaas sorpaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andresilva andresilva force-pushed the andre/minor-fixes branch from 24159f8 to c94165e Compare June 1, 2018 13:33
@andresilva andresilva force-pushed the andre/minor-fixes branch from 7c659da to ae79f64 Compare June 1, 2018 14:31
@andresilva andresilva force-pushed the andre/minor-fixes branch from ae79f64 to 4e442bf Compare June 1, 2018 14:36
@andresilva andresilva mentioned this pull request Jun 19, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomusdrw tomusdrw Awaiting requested review from tomusdrw

2 more reviewers

@kirushik kirushik kirushik approved these changes

@sorpaas sorpaas sorpaas approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@andresilva @coveralls @kirushik @sorpaas