Skip to content
This repository was archived by the owner on May 24, 2022. It is now read-only.

Commit ee2a222

Browse files
amaury1093Tbaut
authored andcommitted
fix: Fix small bugs after hasty merge (#498)
* Revert @parity/* bump * Fix blockscout link * Pass down ws-origins flag * Fix again: use transactionHash * Update maintainers * Fix broken image in prod
1 parent d0ae207 commit ee2a222

File tree

9 files changed

+71
-36
lines changed

9 files changed

+71
-36
lines changed

package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@
55
"private": true,
66
"author": "Parity Team <[email protected]>",
77
"maintainers": [
8-
"Jaco Greeff",
9-
"Amaury Martiny"
8+
"Axel Chalon",
9+
"Amaury Martiny",
10+
"Thibaut Sardan",
11+
"Luke Schoen"
1012
],
1113
"contributors": [],
1214
"license": "BSD-3-Clause",

packages/fether-electron/package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@
55
"private": true,
66
"author": "Parity Team <[email protected]>",
77
"maintainers": [
8-
"Jaco Greeff",
9-
"Amaury Martiny"
8+
"Axel Chalon",
9+
"Amaury Martiny",
10+
"Thibaut Sardan",
11+
"Luke Schoen"
1012
],
1113
"contributors": [],
1214
"license": "BSD-3-Clause",

packages/fether-electron/src/main/app/cli/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,12 @@ cli
4242
// We want to ignore some flags and not pass them down to Parity:
4343
// --inspect: `electron-webpack dev` runs Electron with the `--inspect` flag for HMR
4444
// -psn_*: https://github.com/paritytech/fether/issues/188
45+
// --ws-interface: we don't pass down this flag, because fether only allows 127.0.0.1 as WS interface
4546
.filter(
4647
arg =>
4748
!arg.startsWith('--inspect') &&
4849
!arg.startsWith('-psn_') &&
49-
!arg.startsWith('--ws-interface') &&
50-
!arg.startsWith('--ws-origins')
50+
!arg.startsWith('--ws-interface')
5151
)
5252
);
5353

packages/fether-electron/src/main/app/methods/setupGlobals.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,12 @@
33
//
44
// SPDX-License-Identifier: BSD-3-Clause
55

6-
import { DEFAULT_WS_PORT, TRUSTED_LOOPBACK } from '../constants';
6+
import { DEFAULT_WS_PORT, IS_PROD, TRUSTED_LOOPBACK } from '../constants';
77
import cli from '../cli';
88

99
function setupGlobals () {
1010
// Globals for fether-react parityStore
11+
global.IS_PROD = IS_PROD;
1112
global.defaultWsInterface = TRUSTED_LOOPBACK;
1213
global.defaultWsPort = DEFAULT_WS_PORT;
1314
global.wsPort = cli.wsPort;

packages/fether-electron/static/preload.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
const { ipcRenderer, remote } = require('electron');
1818

19-
const IS_PROD = process.env.NODE_ENV === 'production';
19+
const IS_PROD = remote.getGlobal('IS_PROD');
2020

2121
function init () {
2222
console.log(

packages/fether-react/package.json

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@
55
"private": true,
66
"author": "Parity Team <[email protected]>",
77
"maintainers": [
8-
"Jaco Greeff",
9-
"Amaury Martiny"
8+
"Axel Chalon",
9+
"Amaury Martiny",
10+
"Thibaut Sardan",
11+
"Luke Schoen"
1012
],
1113
"contributors": [],
1214
"license": "BSD-3-Clause",
@@ -35,11 +37,11 @@
3537
},
3638
"dependencies": {
3739
"@craco/craco": "^4.0.0",
38-
"@parity/abi": "^5.1.1",
39-
"@parity/api": "^5.1.1",
40-
"@parity/contracts": "^5.1.1",
41-
"@parity/light.js": "^5.1.1",
42-
"@parity/light.js-react": "^5.1.1",
40+
"@parity/abi": "5.1.1",
41+
"@parity/api": "5.1.1",
42+
"@parity/contracts": "5.1.1",
43+
"@parity/light.js": "5.1.1",
44+
"@parity/light.js-react": "5.1.1",
4345
"@parity/qr-signer": "^0.3.2",
4446
"bignumber.js": "^8.0.1",
4547
"bip39": "^2.5.0",

packages/fether-react/src/Send/Sent/Sent.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ class Sent extends Component {
167167
<a
168168
href={blockscoutTxUrl(
169169
chainName,
170-
txStatus.confirmed.hash,
170+
txStatus.confirmed.transactionHash,
171171
token.address
172172
)}
173173
target='_blank'

packages/fether-ui/package.json

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,10 @@
55
"private": true,
66
"author": "Parity Team <[email protected]>",
77
"maintainers": [
8-
"Jaco Greeff",
9-
"Amaury Martiny"
8+
"Axel Chalon",
9+
"Amaury Martiny",
10+
"Thibaut Sardan",
11+
"Luke Schoen"
1012
],
1113
"contributors": [],
1214
"license": "BSD-3-Clause",
@@ -56,4 +58,4 @@
5658
"prop-types": "^15.6.1",
5759
"react": "^16.4.0"
5860
}
59-
}
61+
}

yarn.lock

Lines changed: 43 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1640,6 +1640,15 @@
16401640
universal-user-agent "^2.0.0"
16411641
url-template "^2.0.8"
16421642

1643+
1644+
version "5.1.1"
1645+
resolved "https://registry.yarnpkg.com/@parity/abi/-/abi-5.1.1.tgz#a91b1483ef969ede7c1a29c59fa5dd39b4880f51"
1646+
integrity sha512-in+1ubZq69yWgZQzjp8SLcwnhKSqV4LLpzjbDA4lJsE/BJtsCndJ8HWBjiv690Ej9v2TgggRyuyrF091j2Eluw==
1647+
dependencies:
1648+
bignumber.js "^8.0.1"
1649+
js-sha3 "0.8.0"
1650+
utf8 "^3.0.0"
1651+
16431652
"@parity/abi@^5.1.1", "@parity/abi@^5.1.3":
16441653
version "5.1.3"
16451654
resolved "https://registry.yarnpkg.com/@parity/abi/-/abi-5.1.3.tgz#0503b3e541c6e02824f86000cef6fca0a0d9ab81"
@@ -1649,7 +1658,24 @@
16491658
js-sha3 "0.8.0"
16501659
utf8 "^3.0.0"
16511660

1652-
"@parity/api@^5.1.1", "@parity/api@^5.1.3":
1661+
1662+
version "5.1.1"
1663+
resolved "https://registry.yarnpkg.com/@parity/api/-/api-5.1.1.tgz#3ac522262f68f23910193b5ab9a37fd261701c14"
1664+
integrity sha512-JPngq2ifejXDhAJ4Xhx7vVr5LeDRvsm6UW1QBRIlm8bpqeaAUw9nwoyvxGZC/JUI9Riq4WjaHYGIa6ZRvpd0rg==
1665+
dependencies:
1666+
"@parity/abi" "^5.1.1"
1667+
bignumber.js "^8.0.1"
1668+
blockies "0.0.2"
1669+
es6-error "4.0.2"
1670+
es6-promise "^4.1.1"
1671+
eventemitter3 "^3.1.0"
1672+
isomorphic-fetch "^2.2.1"
1673+
js-sha3 "0.8.0"
1674+
lodash "^4.17.11"
1675+
store "^2.0.12"
1676+
websocket "^1.0.25"
1677+
1678+
"@parity/api@^5.1.1":
16531679
version "5.1.3"
16541680
resolved "https://registry.yarnpkg.com/@parity/api/-/api-5.1.3.tgz#c4c1a5c0cbc41d75ad8a58f37a478a09ce5d0ea3"
16551681
integrity sha512-UiN2mdgkEIID/rsqRRBn5AMtIPvrXhJhrwGLXL3vWf9EsiF0GfTuIBYqflz0nPTZY1PySa7hi1XwOmnqprdqNg==
@@ -1666,13 +1692,13 @@
16661692
store "^2.0.12"
16671693
websocket "^1.0.25"
16681694

1669-
"@parity/contracts@^5.1.1":
1670-
version "5.1.3"
1671-
resolved "https://registry.yarnpkg.com/@parity/contracts/-/contracts-5.1.3.tgz#736cc9935117b9d1e86ed094a65fa60de085b6e5"
1672-
integrity sha512-TRq0BUUrg61MG9ByTu0UqBySYKncLtR17vx3UV1NKxi9lWS33jYlessEz5CZXr1t5ILt0tN/PYzYe+w1Brm7LQ==
1695+
1696+
version "5.1.1"
1697+
resolved "https://registry.yarnpkg.com/@parity/contracts/-/contracts-5.1.1.tgz#c00c9a194882850de9ed3646f4bd25e8610d87a8"
1698+
integrity sha512-9JFzSGjn5W4tyfpDDznVlErxZiIYRp0e4uzIqAerPQOKFvZZdw00NVHUJkwLcoXJmwIMQQxy/X2ZByQSY3x1TQ==
16731699
dependencies:
1674-
"@parity/abi" "^5.1.3"
1675-
"@parity/api" "^5.1.3"
1700+
"@parity/abi" "^5.1.1"
1701+
"@parity/api" "^5.1.1"
16761702
bignumber.js "^8.0.1"
16771703

16781704
"@parity/electron@^5.1.0":
@@ -1694,21 +1720,21 @@
16941720
resolved "https://registry.yarnpkg.com/@parity/erc681/-/erc681-0.1.1.tgz#0ade5233751011c15d5e75bd2bb583a9ba450a5e"
16951721
integrity sha512-OGDAWbAcm4mh+wzw6uBYxw0OJtqJ+39W3pOXl0W93d2p/cH7ppfvunwf7irEPw0FPiAIuR/F77nU1zMKNhm8Dg==
16961722

1697-
"@parity/light.js-react@^5.1.1":
1698-
version "5.1.3"
1699-
resolved "https://registry.yarnpkg.com/@parity/light.js-react/-/light.js-react-5.1.3.tgz#f7e28a0ecbd05246c99cc3f20b4c8cf96c44210f"
1700-
integrity sha512-t7BTy7ECrPJzoXle3gOWurK47+PEltHrfajJStvFgzVG0oyKKyrvb5ro3w2YIOc51L9tfHX0eeS1tuvUeCJLvQ==
1723+
1724+
version "5.1.1"
1725+
resolved "https://registry.yarnpkg.com/@parity/light.js-react/-/light.js-react-5.1.1.tgz#1b5e1b62dd04fa846e8d11971742ec793500fe0c"
1726+
integrity sha512-LD05kpHLzhgONeFiGEKrN59LBSmeBzx5NakxBXzu8vixBQt6Cyq5z1gOzg4RtbtkcTrUC7Q02H4DwOh8QJpNmw==
17011727
dependencies:
17021728
recompose "^0.30.0"
17031729
symbol-observable "^1.2.0"
17041730

1705-
"@parity/light.js@^5.1.1":
1706-
version "5.1.3"
1707-
resolved "https://registry.yarnpkg.com/@parity/light.js/-/light.js-5.1.3.tgz#cb8b5e22916234cf66d446d7eeaf0f030265f9da"
1708-
integrity sha512-SVwGb02QGqlbICqVmg6jqCDW7VMtAzl08YtH9bGFFbYDY9XRyD/bisxnujyecAk9YyduhPUrNu8gLpk+yDrW+Q==
1731+
1732+
version "5.1.1"
1733+
resolved "https://registry.yarnpkg.com/@parity/light.js/-/light.js-5.1.1.tgz#141f4c168f46208b1caa6273161ad9a8b1675862"
1734+
integrity sha512-AJ/klFpim+lKLxYKpIhJL9Btu4OuXs43lfbBK8XA0kXOV6M51vCv5n+sO5oTWVx6IJE3lXuDIc674H9BC4fcvQ==
17091735
dependencies:
1710-
"@parity/abi" "^5.1.3"
1711-
"@parity/api" "^5.1.3"
1736+
"@parity/abi" "^5.1.1"
1737+
"@parity/api" "^5.1.1"
17121738
async-retry "^1.2.3"
17131739
bignumber.js "^8.0.1"
17141740
debug "^4.1.0"

0 commit comments

Comments
 (0)