Fix evaluation of linear functions with EvalPoly
#1097
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to v1.3.0
Update to v1.3.1
Updates to v1.4
Updates to v1.4.1
Updates to v1.4.2
The `internalEvalPolyLinearWithPrecomp` contained an off-by-one error that caused it to throw an exception when the polynomial to evaluate was a linear function. This patch fixes that mistake, and adds a test that evaluates a linear polynomial on a CKKS ciphertext. Bug discovered and patched at AccelCom, Barcelona Supercomputing Center.
Collaborator
|
@hsanzg, please apply your changes to the dev branch and resubmit. |
Collaborator
Author
|
Sorry for the delay, I see you've already created a new branch and merge request targeting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
internalEvalPolyLinearWithPrecompmethod contained an off-by-one error that caused it to throw an exception when the polynomial to evaluate was a linear function. This patch fixes that mistake, and adds a test that evaluates a linear polynomial on a CKKS ciphertext.Fixes #1096